Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Issue 8346032: Allow inlining of named function expressions containing ThisFunction reference. (Closed)

Created:
9 years, 2 months ago by fschneider
Modified:
9 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Allow inlining of named function expressions containing ThisFunction reference. Named function expression have an implicit local variable that refers to the current function (ThisFunction). Before we only could inline anonymous function expressions like: A.prototype.foo = function() {} as opposed to A.prototype.foo = function foo() {} This change enables inlining function of expressions like this. Committed: http://code.google.com/p/v8/source/detail?r=9699

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +10 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 2 months ago (2011-10-19 11:01:49 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 2 months ago (2011-10-19 11:32:19 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698