Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 8346017: Move content_browser_client.h to public, and while at it, move (Closed)

Created:
9 years, 2 months ago by Jói
Modified:
9 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, michaeln, Avi (use Gerrit), creis+watch_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, ajwong+watch_chromium.org, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Move content_browser_client.h to public, and while at it, move window_container_type.h as well since it is included by content_browser_client.h BUG=98716 TEST=it builds + existing tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106323

Patch Set 1 #

Patch Set 2 : Merge to r106167 (previous change in pipeline) #

Patch Set 3 : Missed a file post merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -498 lines) Patch
M chrome/browser/background/background_contents_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/background_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents_drag_source.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view_host.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/appcache/chrome_appcache_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_child_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_url_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browsing_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/content_browser_client.h View 1 1 chunk +0 lines, -351 lines 0 comments Download
M content/browser/debugger/devtools_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/debugger/devtools_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/debugger/devtools_netlog_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/debugger/render_view_devtools_agent_host.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/download/base_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_item.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/download/download_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/download/save_package.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/geolocation/arbitrator_dependency_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mock_content_browser_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/browser_render_process_host.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/buffered_resource_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/clipboard_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/socket_stream_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/x509_user_cert_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_input_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_client_auth_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_policy.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/tab_contents/navigation_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/render_view_host_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/utility_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/zygote_host_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -1 line 0 comments Download
D content/common/window_container_type.h View 1 chunk +0 lines, -36 lines 0 comments Download
D content/common/window_container_type.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M content/content_browser.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/public/browser/content_browser_client.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + content/public/common/window_container_type.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/public/common/window_container_type.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/shell_content_browser_client.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Jói
WindowContainerType is not an abstract/pure virtual class, but I moved it along with ContentBrowserClient as ...
9 years, 2 months ago (2011-10-18 23:27:11 UTC) #1
jam
9 years, 2 months ago (2011-10-19 04:29:39 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698