Make builtin functions be skipped in stack traces.

Make builtin functions be skipped in stack traces.

Does include exposed builtin functions ("native functions").

Committed: http://code.google.com/p/v8/source/detail?r=9723

[Erik Corry, 2011-10-19 07:22:27]

Wot no tests?

[Lasse Reichstein, 2011-10-19 08:15:32]

Tests incoming, please hold.

[Lasse Reichstein, 2011-10-19 08:56:26]

Now with tests. Feel free to review.

[rossberg, 2011-10-19 13:58:20]

Can we perhaps have a flag to control this? I would be really lost debugging
proxies if I did not see any builtins in my stack traces.

[Lasse Reichstein, 2011-10-20 07:58:13]

Good point.
Added flag, and made it turn off all attempts at avoiding builtins in the stack
trace.
Also, the heuristic we used for excluding builtins could be simplified a lot.

Please look again.

[rossberg, 2011-10-20 12:15:35]

lgtm

[Rico, 2011-10-20 12:17:33]

LGTM

http://codereview.chromium.org/8345039/diff/5001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/8345039/diff/5001/src/runtime.cc#newcode12973
src/runtime.cc:12973: if (!raw_fun->IsJSFunction())
well you added them above, so how about a pair of {} here as well

http://codereview.chromium.org/8345039/diff/5001/src/runtime.cc#newcode12984
src/runtime.cc:12984: // The --builtins-in-stack-traces command line flag allows
including
--builtins-in-stack-traces -> --builtins-in-stack-trace

http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2.js
File test/mjsunit/stack-traces-2.js (right):

http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2....
test/mjsunit/stack-traces-2.js:1: // Copyright 2009 the V8 project authors. All
rights reserved.
2011

http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2....
test/mjsunit/stack-traces-2.js:80: // Omitted because QuickSort has builtins
object as receiver, and is non-native
Comment is slightly misleading, it is not omitted in this case due to the flag

http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2....
test/mjsunit/stack-traces-2.js:83: (b < a) - (a < b); });
indention seems off here

http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2....
test/mjsunit/stack-traces-2.js:86: // Omitted because ADD from runtime.js is
non-native builtin.
Also slightly misleading

[Lasse Reichstein, 2011-10-20 12:26:09]

http://codereview.chromium.org/8345039/diff/5001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/8345039/diff/5001/src/runtime.cc#newcode12973
src/runtime.cc:12973: if (!raw_fun->IsJSFunction())
Absolutely.

http://codereview.chromium.org/8345039/diff/5001/src/runtime.cc#newcode12984
src/runtime.cc:12984: // The --builtins-in-stack-traces command line flag allows
including
I'm renaming it to -trace*s*. I've misspelled it consistently every time I've
written it, so with the 's' seems to be the most obvious name.

http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2.js
File test/mjsunit/stack-traces-2.js (right):

http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2....
test/mjsunit/stack-traces-2.js:80: // Omitted because QuickSort has builtins
object as receiver, and is non-native
On 2011/10/20 12:17:33, Rico wrote:
> Comment is slightly misleading, it is not omitted in this case due to the flag

Done.

http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2....
test/mjsunit/stack-traces-2.js:83: (b < a) - (a < b); });
Off by a "Not". Fixed.

http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2....
test/mjsunit/stack-traces-2.js:86: // Omitted because ADD from runtime.js is
non-native builtin.
On 2011/10/20 12:17:33, Rico wrote:
> Also slightly misleading 

Done.