Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2011 the V8 project authors. All rights reserved. | 1 // Copyright 2011 the V8 project authors. All rights reserved. |
| 2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without |
| 3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are |
| 4 // met: | 4 // met: |
| 5 // | 5 // |
| 6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright |
| 7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. |
| 8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above |
| 9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following |
| 10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided |
| (...skipping 2776 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 2787 return Utils::ToLocal(result); | 2787 return Utils::ToLocal(result); |
| 2788 } | 2788 } |
| 2789 | 2789 |
| 2790 | 2790 |
| 2791 Local<Value> v8::Object::Get(uint32_t index) { | 2791 Local<Value> v8::Object::Get(uint32_t index) { |
| 2792 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); | 2792 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); |
| 2793 ON_BAILOUT(isolate, "v8::Object::Get()", return Local<v8::Value>()); | 2793 ON_BAILOUT(isolate, "v8::Object::Get()", return Local<v8::Value>()); |
| 2794 ENTER_V8(isolate); | 2794 ENTER_V8(isolate); |
| 2795 i::Handle<i::JSObject> self = Utils::OpenHandle(this); | 2795 i::Handle<i::JSObject> self = Utils::OpenHandle(this); |
| 2796 EXCEPTION_PREAMBLE(isolate); | 2796 EXCEPTION_PREAMBLE(isolate); |
| 2797 i::Handle<i::Object> result = i::GetElement(self, index); | 2797 i::Handle<i::Object> result = i::Object::GetElement(self, index); |
| 2798 has_pending_exception = result.is_null(); | 2798 has_pending_exception = result.is_null(); |
| 2799 EXCEPTION_BAILOUT_CHECK(isolate, Local<Value>()); | 2799 EXCEPTION_BAILOUT_CHECK(isolate, Local<Value>()); |
| 2800 return Utils::ToLocal(result); | 2800 return Utils::ToLocal(result); |
| 2801 } | 2801 } |
| 2802 | 2802 |
| 2803 | 2803 |
| 2804 PropertyAttribute v8::Object::GetPropertyAttributes(v8::Handle<Value> key) { | 2804 PropertyAttribute v8::Object::GetPropertyAttributes(v8::Handle<Value> key) { |
| 2805 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); | 2805 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); |
| 2806 ON_BAILOUT(isolate, "v8::Object::GetPropertyAttribute()", | 2806 ON_BAILOUT(isolate, "v8::Object::GetPropertyAttribute()", |
| 2807 return static_cast<PropertyAttribute>(NONE)); | 2807 return static_cast<PropertyAttribute>(NONE)); |
| (...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 3086 i::Handle<i::String> name, | 3086 i::Handle<i::String> name, |
| 3087 i::LookupResult* lookup) { | 3087 i::LookupResult* lookup) { |
| 3088 if (!lookup->IsProperty()) { | 3088 if (!lookup->IsProperty()) { |
| 3089 // No real property was found. | 3089 // No real property was found. |
| 3090 return Local<Value>(); | 3090 return Local<Value>(); |
| 3091 } | 3091 } |
| 3092 | 3092 |
| 3093 // If the property being looked up is a callback, it can throw | 3093 // If the property being looked up is a callback, it can throw |
| 3094 // an exception. | 3094 // an exception. |
| 3095 EXCEPTION_PREAMBLE(isolate); | 3095 EXCEPTION_PREAMBLE(isolate); |
| 3096 PropertyAttributes attributes; | 3096 PropertyAttributes ignored; |
| 3097 i::Handle<i::Object> result = i::Object::GetProperty(isolate, | 3097 i::Handle<i::Object> result = |
| 3098 receiver, | 3098 i::Object::GetProperty(receiver, receiver, lookup, name, |
| 3099 receiver, | 3099 &ignored); |
|
ulan
2011/10/19 08:48:12
I thought we had a convention that we put each arg
| |
| 3100 lookup, | |
| 3101 name, | |
| 3102 &attributes); | |
| 3103 has_pending_exception = result.is_null(); | 3100 has_pending_exception = result.is_null(); |
| 3104 EXCEPTION_BAILOUT_CHECK(isolate, Local<Value>()); | 3101 EXCEPTION_BAILOUT_CHECK(isolate, Local<Value>()); |
| 3105 | 3102 |
| 3106 return Utils::ToLocal(result); | 3103 return Utils::ToLocal(result); |
| 3107 } | 3104 } |
| 3108 | 3105 |
| 3109 | 3106 |
| 3110 Local<Value> v8::Object::GetRealNamedPropertyInPrototypeChain( | 3107 Local<Value> v8::Object::GetRealNamedPropertyInPrototypeChain( |
| 3111 Handle<String> key) { | 3108 Handle<String> key) { |
| 3112 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); | 3109 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); |
| (...skipping 2984 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 6097 | 6094 |
| 6098 | 6095 |
| 6099 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) { | 6096 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) { |
| 6100 HandleScopeImplementer* scope_implementer = | 6097 HandleScopeImplementer* scope_implementer = |
| 6101 reinterpret_cast<HandleScopeImplementer*>(storage); | 6098 reinterpret_cast<HandleScopeImplementer*>(storage); |
| 6102 scope_implementer->IterateThis(v); | 6099 scope_implementer->IterateThis(v); |
| 6103 return storage + ArchiveSpacePerThread(); | 6100 return storage + ArchiveSpacePerThread(); |
| 6104 } | 6101 } |
| 6105 | 6102 |
| 6106 } } // namespace v8::internal | 6103 } } // namespace v8::internal |
| OLD | NEW |