SpellCheck: the custom dictionary should be per profile.

chrome/browser/spellchecker/spellcheck_profile.h

Index: chrome/browser/spellchecker/spellcheck_profile.h
diff --git a/chrome/browser/spellchecker/spellcheck_profile.h b/chrome/browser/spellchecker/spellcheck_profile.h
index 7a7bf0d511aca8cd8ba34b7f3e735de0823670ef..339920dcdbfb471cfa662e7cf0d668c105a76f29 100644
--- a/chrome/browser/spellchecker/spellcheck_profile.h
+++ b/chrome/browser/spellchecker/spellcheck_profile.h
@@ -9,6 +9,7 @@
 #include <string>
 #include <vector>
 
+#include "base/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/spellchecker/spellcheck_profile_provider.h"
@@ -56,7 +57,7 @@ class SpellCheckProfile : public SpellCheckProfileProvider {
     REINITIALIZE_DID_NOTHING
   };
 
-  SpellCheckProfile();
+  explicit SpellCheckProfile(const FilePath& profile_dir);
   virtual ~SpellCheckProfile();
 
   // Retrieves SpellCheckHost object.
@@ -86,6 +87,10 @@ class SpellCheckProfile : public SpellCheckProfileProvider {
   virtual const CustomWordList& GetCustomWords() const;
   virtual void CustomWordAddedLocally(const std::string& word);
 
+  // Methods about custom dictionary.

[Hironori Bono, 2011/10/20 04:48:50]

nit: we do not need this comment and the blank line above because the following
functions are override ones.

[shinyak (Google), 2011/10/20 12:04:52]

Done.

+  virtual void LoadCustomDictionary(CustomWordList* custom_words);

[Hironori Bono, 2011/10/20 04:48:50]

nit: is it possible to add 'OVERRIDE' keywords to all override functions in this
class? (We also need to include "base/compiler_specific.h".)

[shinyak (Google), 2011/10/20 12:04:52]

Done.

+  virtual void WriteWordToCustomDictionary(const std::string& word);
+
  protected:
   // Only tests should override this.
   virtual SpellCheckHost* CreateHost(
@@ -100,6 +105,8 @@ class SpellCheckProfile : public SpellCheckProfileProvider {
   scoped_refptr<SpellCheckHost> host_;
   scoped_ptr<SpellCheckHostMetrics> metrics_;
 
+  const FilePath& GetCustomDictionaryPath();

[Hironori Bono, 2011/10/20 04:48:50]

This function should be above of |host_| to follow our coding rule:
<http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Declar...>

[shinyak (Google), 2011/10/20 12:04:52]

Done.

+
   // Indicates whether |host_| has told us initialization is
   // finished.
   bool host_ready_;
@@ -107,6 +114,11 @@ class SpellCheckProfile : public SpellCheckProfileProvider {
   // In-memory cache of the custom words file.
   scoped_ptr<CustomWordList> custom_words_;
 
+  // A directory path of profile.
+  FilePath profile_dir_;
+  // A path for custom dictionary per profile.
+  FilePath custom_dictionary_path_;

[Hironori Bono, 2011/10/20 04:48:50]

nit: can we use scoped_ptr<FilePath> to avoid allocating memory for this
variable when we do not use custom dictionaries?

[shinyak (Google), 2011/10/20 12:04:52]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(SpellCheckProfile);
 };