Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.h

Issue 8345033: Collect some histograms about signed binary downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.h
===================================================================
--- chrome/browser/safe_browsing/safe_browsing_service.h (revision 106761)
+++ chrome/browser/safe_browsing/safe_browsing_service.h (working copy)
@@ -267,6 +267,8 @@
return csd_service_.get();
}
+ // The DownloadProtectionService is not valid after the SafeBrowsingService
+ // is destroyed.
safe_browsing::DownloadProtectionService*
download_protection_service() const {
return download_service_.get();
@@ -472,6 +474,10 @@
// starts or stops the service accordingly.
void RefreshState();
+ // Arranges to delete |download_service_| on the IO thread, and sets
+ // the pointer to NULL.
+ void ShutDownDownloadService();
+
// The factory used to instanciate a SafeBrowsingService object.
// Useful for tests, so they can provide their own implementation of
// SafeBrowsingService.
@@ -556,7 +562,7 @@
// The DownloadProtectionService is managed by the SafeBrowsingService,
// since its running state and lifecycle depends on SafeBrowsingService's.
- scoped_refptr<safe_browsing::DownloadProtectionService> download_service_;
+ scoped_ptr<safe_browsing::DownloadProtectionService> download_service_;
DISALLOW_COPY_AND_ASSIGN(SafeBrowsingService);
};

Powered by Google App Engine
This is Rietveld 408576698