Collect some histograms about signed binary downloads.

chrome/browser/safe_browsing/safe_browsing_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/path_service.h"
@@ skipping 157 matching lines @@
       closing_database_(false),
       download_urlcheck_timeout_ms_(kDownloadUrlCheckTimeoutMs),
       download_hashcheck_timeout_ms_(kDownloadHashCheckTimeoutMs) {
 #if !defined(OS_CHROMEOS)
   if (!CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kDisableClientSidePhishingDetection)) {
     csd_service_.reset(
         safe_browsing::ClientSideDetectionService::Create(
             g_browser_process->system_request_context()));
   }
-  if (CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kEnableImprovedDownloadProtection)) {
-    download_service_ = new safe_browsing::DownloadProtectionService(
-        this,
-        g_browser_process->system_request_context());
-  }
+  download_service_ = new safe_browsing::DownloadProtectionService(
+      AsWeakPtr(),
+      g_browser_process->system_request_context());
 #endif
 }
 
 SafeBrowsingService::~SafeBrowsingService() {
   // Deletes the PrefChangeRegistrars, whose dtors also unregister |this| as an
   // observer of the preferences.
   STLDeleteValues(&prefs_map_);
 
   // We should have already been shut down. If we're still enabled, then the
   // database isn't going to be closed properly, which could lead to corruption.
@@ skipping 1167 matching lines @@
     }
   }
 
   if (enable)
     Start();
   else
     Stop();
 
   if (csd_service_.get())
     csd_service_->SetEnabled(enable);
-  if (download_service_.get())
-    download_service_->SetEnabled(enable);
+  if (download_service_.get()) {
+    download_service_->SetEnabled(
+        enable && CommandLine::ForCurrentProcess()->HasSwitch(
+            switches::kEnableImprovedDownloadProtection));

[mattm, 2011/10/19 18:54:12]

So this isn't aiming to get histograms from users in the wild at this point?

[Brian Ryner, 2011/10/19 19:20:11]

It will, because we only check the "enabled" state after collecting the
signed-binary histogram.

+  }
 }