Print Preview: Adding support for localized margin units and format.

chrome/browser/resources/print_preview/print_preview_utils_test.html

Index: chrome/browser/resources/print_preview/print_preview_utils_test.html
diff --git a/chrome/browser/resources/print_preview/print_preview_utils_test.html b/chrome/browser/resources/print_preview/print_preview_utils_test.html
index c6339542a0c0964a3da78069adf04cfa3fbc6fae..3d2106171e6cd8165d8ebb096ff317f8b4aac444 100644
--- a/chrome/browser/resources/print_preview/print_preview_utils_test.html
+++ b/chrome/browser/resources/print_preview/print_preview_utils_test.html
@@ -114,7 +114,19 @@ function testConvertInchesToPoints() {
 function testConvertPointsToInches() {
   assertEquals(convertPointsToInches(72), 1);
   assertEquals(convertPointsToInches(144), 2);
-  assertEquals(convertPointsToInches(32.4), 0.45);
+  assertEquals(convertPointsToInches(36), 0.5);
+}
+
+function testConvertMillimetersToPoints() {
+  assertEquals(convertMillimetersToPoints(10), 28.3464567);

[Evan Stade, 2011/10/22 00:30:45]

I don't think these tests are super useful, you are basically just asserting
that a constant somewhere has a particular value. If for some mystifying reason
you ever did want to change that constant, then you'd have to change these tests
as well, so all you've done is added work. These tests would make sense if they
were testing something more complicated than the multiplication operator.

[dpapad, 2011/10/22 00:47:29]

I agree. Basically these tests only cover the case where on of those 2 constants
is changed accidentally. I can remove if this is not enough value to justify
adding them.

+  assertEquals(convertMillimetersToPoints(20), 56.6929134);
+  assertEquals(convertMillimetersToPoints(4.5), 12.755905515);
+}
+
+function testConvertPointsToMillimeters() {
+  assertEquals(convertPointsToMillimeters(73.70078742), 26);
+  assertEquals(convertPointsToMillimeters(34.01574804), 12);
+  assertEquals(convertPointsToMillimeters(144.56692917), 51);
 }
 
 </script>