Print Preview: Adding support for localized margin units and format.

chrome/browser/resources/print_preview/print_preview_utils.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Returns true if |toTest| contains only digits. Leading and trailing
  * whitespace is allowed.
  * @param {string} toTest The string to be tested.
  */
 function isInteger(toTest) {
@@ skipping 188 matching lines @@
  * @return {number} The random integer.
  */
 function randomInteger(endPointA, endPointB) {
   from = Math.min(endPointA, endPointB);
   to = Math.max(endPointA, endPointB);
   return Math.floor(Math.random() * (to - from + 1) + from);
 }
 
 // Number of points per inch.
 POINTS_PER_INCH = 72;
+POINTS_PER_MILLIMETER = 2.83464567;

[Evan Stade, 2011/10/21 01:33:02]

technically should start with var

[dpapad, 2011/10/21 16:12:48]

Done.

 
 /**
  * Converts |value| from inches to points.
  * @param {number} value The number in inches.
  * @return {number} |value| in points.
  */
 function convertInchesToPoints(value) {
   return value * POINTS_PER_INCH;
 }
 
 /**
  * Converts |value| from points to inches.
  * @param {number} value The number in points.
  * @return {number} |value| in inches.
  */
 function convertPointsToInches(value) {
   return value / POINTS_PER_INCH;
 }
+
+/**
+ * Converts |value| from centimeters to points.
+ * @param {number} value The number in centimeters.
+ * @return {number} |value| in points.
+ */
+function convertMillimetersToPoints(value) {

[Evan Stade, 2011/10/21 01:33:02]

I would not create these functions. Just multiply by the vars whenever you need
them.

[dpapad, 2011/10/21 16:12:48]

I prefer to keep them (along with convertInchesToPoints and vice versa). This
way the conversions can be tested in print_preview_utils_test.html and it also
improves readability.

+  return value * POINTS_PER_MILLIMETER;
+}
+
+/**
+ * Converts |value| from points to centimeters..

[Evan Stade, 2011/10/21 01:33:02]

not cm

[dpapad, 2011/10/21 16:12:48]

Done.

+ * @param {number} value The number in points.
+ * @return {number} |value| in centimeters.
+ */
+function convertPointsToMillimeters(value) {
+  return value / POINTS_PER_MILLIMETER;
+}