Print Preview: Adding support for localized margin units and format.

chrome/browser/resources/print_preview/margin_settings.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * Creates a Margins object that holds four margin values. The units in which
    * the values are expressed can be any numeric value.
@@ skipping 54 matching lines @@
      * @return {array} An array of string indices.
      * @private
      */
     indicesAsArray_: function() {
       return [MarginSettings.LEFT_GROUP, MarginSettings.TOP_GROUP,
           MarginSettings.RIGHT_GROUP, MarginSettings.BOTTOM_GROUP];
     },
 
     /**
      * Rounds |this| based on the precision used when displaying the margins in
-     * inches. This is done by converting from points to inches and back to
-     * points.
+     * the user's prefered units. This is done by converting from points to
+     * those units (mm/inches) and back to points.
      */
-    roundToInches: function() {
+    roundToUserLocaleUnits: function() {
       var indicesAsArray = this.indicesAsArray_();
       for (var i = 0; i < indicesAsArray.length; i++) {
         this[indicesAsArray[i]] =
-            print_preview.convertPointsToInchesTextAndBack(
+            print_preview.convertPointsToUserLocaleUnitsAndBack(
                 this[indicesAsArray[i]]);
       }
     },
-
-    /**
-     * Converts |this| to inches and returns the result in a new Margins object.
-     * |this| is not affected. It assumes that |this| is currently expressed in
-     * points.
-     * @param {number} The number of decimal points to keep.
-     * @return {Margins} The equivalent of |this| in inches.
-     */
-    toInches: function(precision) {
-      return new Margins(
-          Margins.roundToPrecision(convertPointsToInches(
-              this[MarginSettings.LEFT_GROUP]), precision),
-          Margins.roundToPrecision(convertPointsToInches(
-              this[MarginSettings.TOP_GROUP]), precision),
-          Margins.roundToPrecision(convertPointsToInches(
-              this[MarginSettings.RIGHT_GROUP]), precision),
-          Margins.roundToPrecision(convertPointsToInches(
-              this[MarginSettings.BOTTOM_GROUP]), precision)
-      );
-    }
   };
 
   /**
    * @constructor
    * Class describing the layout of the page.
    */
   function PageLayout(width, height, left, top, right, bottom) {
     this.contentWidth_ = width;
     this.contentHeight_ = height;
     this.margins_ = new Margins(left, top, right, bottom);
@@ skipping 63 matching lines @@
   MarginSettings.DEFAULT_MARGINS_OPTION_INDEX = 0;
   // Group name corresponding to the top margin.
   MarginSettings.TOP_GROUP = 'top';
   //  Group name corresponding to the left margin.
   MarginSettings.LEFT_GROUP = 'left';
   // Group name corresponding to the right margin.
   MarginSettings.RIGHT_GROUP = 'right';
   // Group name corresponding to the bottom margin.
   MarginSettings.BOTTOM_GROUP = 'bottom';
 
+  /**
+   * Extracts the number formatting and measurement system for the current
+   * locale.
+   * @param {string} numberFormat Is the formatted version of a sample number,
+   *     sent from the backend.
+   * @oaram {number} measurementSystem 0 for SI (aka metric system), 1 for the
+   *     system used in the US. Note: Mathces UMeasurementSystem enum in
+   *     third_party/icu/public/i18n/unicode/ulocdata.h.
+   */
+  MarginSettings.setNumberFormatAndMeasurementSystem = function(
+      numberFormat, measurementSystem) {
+    var regex = /^(\d+)(\.|\,)(\d+)(\.|\,)(\d+)$/;
+    var matches = numberFormat.match(regex);
+    MarginSettings.thousandsPoint = matches[2];
+    MarginSettings.decimalPoint = matches[4];
+    MarginSettings.useMetricSystem = measurementSystem == 0;
+  };
+
   cr.addSingletonGetter(MarginSettings);
 
   MarginSettings.prototype = {
     /**
      * Returns a dictionary of the four custom margin values.
      * @return {object}
      */
     get customMargins() {
       var margins = {};
       margins.marginLeft = this.customMargins_.left;
@@ skipping 50 matching lines @@
     },
 
     /**
      * If the custom margin values have changed then request a new preview based
      * on the newly set margins.
      * @private
      */
     requestPreviewIfNeeded_: function() {
       if (!this.areMarginSettingsValid())
         return;
-      if (this.customMargins_.toInches(2).isEqual(
-          this.previousCustomMargins_.toInches(2))) {
+      if (this.customMargins_.isEqual(this.previousCustomMargins_))
         return;
-      }
       this.previousCustomMargins_.copy(this.customMargins_);
       setDefaultValuesAndRegeneratePreview(false);
     },
 
     /**
      * Listener executed when the mouse is over the sidebar. If the custom
      * margin lines are displayed, then, it fades them out.
      * @private
      */
     onSidebarMouseOver_: function(e) {
@@ skipping 82 matching lines @@
           MarginSettings.MINIMUM_MARGINS_DISTANCE;
       marginValueLimits[1] = this.pageWidth_ - this.customMargins_.right -
           MarginSettings.MINIMUM_MARGINS_DISTANCE;
       marginValueLimits[2] = this.pageWidth_ - this.customMargins_.left -
           MarginSettings.MINIMUM_MARGINS_DISTANCE;
       marginValueLimits[3] = this.pageHeight_ - this.customMargins_.top -
           MarginSettings.MINIMUM_MARGINS_DISTANCE;
 
       for (var i = 0; i < marginValueLimits.length; i++) {
         marginValueLimits[i] = Math.max(marginValueLimits[i], 0);
-        marginValueLimits[i] = print_preview.convertPointsToInchesTextAndBack(
-            marginValueLimits[i]);
+        marginValueLimits[i] =
+            print_preview.convertPointsToUserLocaleUnitsAndBack(

[Evan Stade, 2011/10/21 01:33:02]

nit: s/UserLocale/Locale/

here and elsewhere

[dpapad, 2011/10/21 16:12:48]

Done.

+                marginValueLimits[i]);
       }
       return marginValueLimits;
     },
 
     /**
      * @return {array} The margin value limits positions normalized to the total
      *     width and height of the plugin and with respect to the top left
      *     corner of the plugin.
      */
     getMarginValueLimitsInPercent_: function() {
@@ skipping 17 matching lines @@
      * When the user stops typing in the margin text box a new print preview is
      * requested, only if
      *   1) The input is compeletely valid (it can be parsed in its entirety).
      *   2) The newly selected margins differ from the previously selected.
      * @param {cr.Event} event The change event holding information about what
      *     changed.
      * @private
      */
     onMarginTextValueMayHaveChanged_: function(event) {
       var marginBox = event.target;
-      var marginBoxValue = convertInchesToPoints(marginBox.margin);
+      var marginBoxValue =
+          print_preview.convertUserLocaleUnitsToPoints(marginBox.margin);
       this.customMargins_[marginBox.marginGroup] = marginBoxValue;
       this.requestPreviewIfNeeded_();
     },
 
     /**
      * @type {print_preview.MarginsUI} The object holding the UI for specifying
      *     custom margins.
      */
     get marginsUI() {
       if (!this.marginsUI_) {
@@ skipping 96 matching lines @@
 
     /**
      * Executes when the custom margins option is selected.
      * @private
      */
     onCustomMarginsSelected_: function() {
       this.addCustomMarginEventListeners_();
 
       if (this.lastSelectedOption_ == MarginSettings.MARGINS_VALUE_DEFAULT) {
         this.customMargins_ = this.currentDefaultPageLayout.margins_;
-        this.customMargins_.roundToInches();
+        this.customMargins_.roundToUserLocaleUnits();
       }
       this.previousCustomMargins_.copy(this.customMargins_);
 
       if (this.previousDefaultPageLayout_ != this.currentDefaultPageLayout) {
         this.pageWidth_ = this.currentDefaultPageLayout.pageWidth;
         this.pageHeight_ = this.currentDefaultPageLayout.pageHeight;
       }
 
       this.previousDefaultPageLayout_ = this.currentDefaultPageLayout;
       this.drawCustomMarginsUI_();
@@ skipping 72 matching lines @@
       if (!previewModifiable)
         fadeOutElement(this.marginsOption_);
     }
   };
 
   return {
     MarginSettings: MarginSettings,
     PageLayout: PageLayout,
   };
 });