Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 8345001: Some extra cflags are needed for cups on OpenBSD. (Closed)

Created:
9 years, 2 months ago by Robert Nagy
Modified:
9 years, 2 months ago
CC:
chromium-reviews, dpapad
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Some extra cflags are needed for cups on OpenBSD. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M printing/printing.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Robert Nagy
9 years, 2 months ago (2011-10-18 16:52:52 UTC) #1
Lei Zhang
lgtm
9 years, 2 months ago (2011-10-18 18:01:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8345001/1
9 years, 2 months ago (2011-10-18 18:01:51 UTC) #3
commit-bot: I haz the power
Presubmit check for 8345001-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 2 months ago (2011-10-18 18:01:53 UTC) #4
Robert Nagy
On 2011/10/18 18:01:53, I haz the power (commit-bot) wrote: > Presubmit check for 8345001-1 failed ...
9 years, 2 months ago (2011-10-18 18:03:51 UTC) #5
Lei Zhang
On 2011/10/18 18:03:51, Robert Nagy wrote: > On 2011/10/18 18:01:53, I haz the power (commit-bot) ...
9 years, 2 months ago (2011-10-18 18:04:53 UTC) #6
Robert Nagy
On 2011/10/18 18:04:53, Lei Zhang wrote: > On 2011/10/18 18:03:51, Robert Nagy wrote: > > ...
9 years, 2 months ago (2011-10-18 18:05:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8345001/1
9 years, 2 months ago (2011-10-18 18:59:34 UTC) #8
commit-bot: I haz the power
9 years, 2 months ago (2011-10-18 20:27:58 UTC) #9
Change committed as 106115

Powered by Google App Engine
This is Rietveld 408576698