Issue 8344085: Revert r106358 "Get rid of RunShell*() functions in gcl.py to finish the conversion to subprocess2"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8344085: Revert r106358 "Get rid of RunShell*() functions in gcl.py to finish the conversion to subprocess2" (Closed)

Created:
9 years, 2 months ago by M-A Ruel

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Revert r106358 "Get rid of RunShell*() functions in gcl.py to finish the conversion to subprocess2" This eats stdout while gcl is committing, which is annoying. It needs tee-like support first. Will revisit this change later, reverting in the meantime. TBR=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106498

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -29 lines)			Patch
	M	gcl.py	View		6 chunks	+43 lines, -23 lines	0 comments	Download
	M	tests/gcl_unittest.py	View		3 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8344085/1

9 years, 2 months ago (2011-10-20 14:54:33 UTC) #2

Change committed as 106498

Expand Messages | Collapse Messages