client/testing/unittest/unittestsuite.dart - Issue 8344084: Do not mark test as successful in callbackDone if test is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/testing/unittest/unittestsuite.dart

Issue 8344084: Do not mark test as successful in callbackDone if test is (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/testing/unittest/unittestsuite.dart

===================================================================

--- client/testing/unittest/unittestsuite.dart (revision 578)

+++ client/testing/unittest/unittestsuite.dart (working copy)

@@ -160,12 +160,10 @@

'More calls to callbackDone() than expected. '

+ 'Actual: ${_callbacksCalled}, expected: ${expected}', '');

_uncaughtError = true;

- } else if (_callbacksCalled == testCase.callbacks) {

+ } else if (_callbacksCalled == testCase.callbacks && !_testIsRunning) {

testCase.recordSuccess();

- if (!_testIsRunning) {

- _currentTest++;

- _nextBatch();

- }

+ _currentTest++;

+ _nextBatch();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »