Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 8344065: Reverting as an experiment to determine if this caused increased Win build (Closed)

Created:
9 years, 2 months ago by James Hawkins
Modified:
9 years, 2 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Reverting as an experiment to determine if this caused increased Win build times. Revert 105754 - base::Bind: Increase the arity to 7. This is required by a CL I have in the works. Stats from builds of Release Chrome target with -j12: Build time: -0.2%, within the noise. Size: No change in size of chrome binary. BUG=98542 TEST=none R=ajwong@chromium.org,akalin@chromium.org,willchan@chromium.org Review URL: http://codereview.chromium.org/8306008 TBR=jhawkins@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106386

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -678 lines) Patch
M base/bind.h View 2 chunks +0 lines, -20 lines 0 comments Download
M base/bind.h.pump View 1 chunk +1 line, -1 line 0 comments Download
M base/bind_internal.h View 14 chunks +7 lines, -649 lines 0 comments Download
M base/bind_internal.h.pump View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
James Hawkins
9 years, 2 months ago (2011-10-19 21:45:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698