Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 8344048: [Mac] Show the edit profile link after a dwell delay so that it doesn't flicker when scrubbing. (Closed)

Created:
9 years, 2 months ago by Robert Sesek
Modified:
9 years, 1 month ago
Reviewers:
sail, sail1
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Show the edit profile link after a dwell delay so that it doesn't flicker when scrubbing. BUG=100856 TEST=Quickly mouse through the avatar menu. The edit link doesn't flicker. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107745

Patch Set 1 #

Patch Set 2 : For testing #

Patch Set 3 : Fix stuck link #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -11 lines) Patch
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm View 1 2 3 2 chunks +41 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm View 1 2 3 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Robert Sesek
9 years, 2 months ago (2011-10-19 16:38:53 UTC) #1
sail
trying the patch right now
9 years, 2 months ago (2011-10-19 16:45:29 UTC) #2
sail
trying the patch right now
9 years, 2 months ago (2011-10-19 16:45:29 UTC) #3
Robert Sesek
OK I think I've resolved the stuck link issue.
9 years, 2 months ago (2011-10-25 22:22:55 UTC) #4
Robert Sesek
ping
9 years, 1 month ago (2011-10-27 14:23:16 UTC) #5
sail
On 2011/10/27 14:23:16, rsesek wrote: > ping Hi Robert. sorry for the delay. The new ...
9 years, 1 month ago (2011-10-27 14:30:08 UTC) #6
Robert Sesek
On 2011/10/27 14:30:08, sail wrote: > On 2011/10/27 14:23:16, rsesek wrote: > > ping > ...
9 years, 1 month ago (2011-10-27 14:31:26 UTC) #7
sail
On 2011/10/27 14:31:26, rsesek wrote: > On 2011/10/27 14:30:08, sail wrote: > > On 2011/10/27 ...
9 years, 1 month ago (2011-10-27 14:34:35 UTC) #8
Robert Sesek
On 2011/10/27 14:34:35, sail wrote: > On 2011/10/27 14:31:26, rsesek wrote: > > On 2011/10/27 ...
9 years, 1 month ago (2011-10-27 16:51:40 UTC) #9
sail1
Cool, out of office right now. Will try after noon. On Oct 27, 2011 9:51 ...
9 years, 1 month ago (2011-10-27 16:53:55 UTC) #10
sail
LGTM! Very cool. The animation works great and the link control never gets stuck. Ship ...
9 years, 1 month ago (2011-10-28 16:06:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/8344048/12001
9 years, 1 month ago (2011-10-28 16:13:21 UTC) #12
commit-bot: I haz the power
9 years, 1 month ago (2011-10-28 17:28:16 UTC) #13
Change committed as 107745

Powered by Google App Engine
This is Rietveld 408576698