courgette/base_test_unittest.cc - Issue 8344037: Start refactoring to reduce executable type knowledge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/base_test_unittest.cc

Issue 8344037: Start refactoring to reduce executable type knowledge. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Attempt to fix diffing weirdness with new file disassembler_win32_x86.cc. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: courgette/base_test_unittest.cc

diff --git a/courgette/base_test_unittest.cc b/courgette/base_test_unittest.cc

index 2a3c0c67ff523163ef5e9f4a8319718c74a5687b..29ca8a0c49ebef32c394fc94627403c5f1e615a9 100644

--- a/courgette/base_test_unittest.cc

+++ b/courgette/base_test_unittest.cc

@@ -7,7 +7,7 @@

#include "base/path_service.h"

void BaseTest::SetUp() {

- PathService::Get(base::DIR_SOURCE_ROOT, &test_dir_);

+ DCHECK(PathService::Get(base::DIR_SOURCE_ROOT, &test_dir_));

test_dir_ = test_dir_.AppendASCII("courgette");

test_dir_ = test_dir_.AppendASCII("testdata");

}