courgette/win32_x86_patcher.h - Issue 8344037: Start refactoring to reduce executable type knowledge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/win32_x86_patcher.h

Issue 8344037: Start refactoring to reduce executable type knowledge. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fix comment. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: courgette/win32_x86_patcher.h

diff --git a/courgette/win32_x86_patcher.h b/courgette/win32_x86_patcher.h

index 6b850217cf7601d69b107329669ccccf766ce1bf..f1aad9dadab8089426fef5fdc868e04f11a37e51 100644

--- a/courgette/win32_x86_patcher.h

+++ b/courgette/win32_x86_patcher.h

@@ -46,9 +46,9 @@ class CourgetteWin32X86Patcher : public TransformationPatcher {

return C_GENERAL_ERROR; // Don't expect any corrected parameters.

AssemblyProgram* program = NULL;

- status = ParseWin32X86PE(ensemble_region_.start() + base_offset_,

- base_length_,

- &program);

+ status = ParseDetectedExecutable(ensemble_region_.start() + base_offset_,

+ base_length_,

+ &program);

if (status != C_OK)

return status;

« no previous file with comments | « courgette/win32_x86_generator.h ('k') | no next file » | no next file with comments »