Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: courgette/disassembler.h

Issue 8344037: Start refactoring to reduce executable type knowledge. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix comment. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/courgette_tool.cc ('k') | courgette/disassembler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/disassembler.h
diff --git a/courgette/disassembler.h b/courgette/disassembler.h
index fa7c908bb9bccdf82caba0747d48690655e16052..bef1a905cb3f5b22c25c6cb7ae0bb4f921206e98 100644
--- a/courgette/disassembler.h
+++ b/courgette/disassembler.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -14,21 +14,14 @@ class PEInfo;
class Disassembler {
public:
- // Factory methods for making disassemblers for various kinds of executables.
- // We have only one so far.
-
- static Disassembler* MakeDisassemberWin32X86(PEInfo* pe_info);
+ virtual ~Disassembler() {}
// Disassembles the item passed to the factory method into the output
// parameter 'program'.
virtual bool Disassemble(AssemblyProgram* program) = 0;
- // Deletes 'this' disassembler.
- virtual void Destroy() = 0;
-
protected:
Disassembler() {}
- virtual ~Disassembler() {}
private:
DISALLOW_COPY_AND_ASSIGN(Disassembler);
« no previous file with comments | « courgette/courgette_tool.cc ('k') | courgette/disassembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698