Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8344013: remove ntp3 resources (Closed)

Created:
9 years, 2 months ago by Evan Stade
Modified:
9 years, 2 months ago
Reviewers:
Dan Beam, Rick Byers
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

remove ntp3 resources BUG=76706 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-10 lines, -2872 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/resources/new_tab.html View 1 chunk +0 lines, -337 lines 0 comments Download
D chrome/browser/resources/new_tab_theme.css View 1 chunk +0 lines, -149 lines 0 comments Download
D chrome/browser/resources/ntp/apps.css View 1 chunk +0 lines, -278 lines 0 comments Download
D chrome/browser/resources/ntp/apps.js View 1 chunk +0 lines, -909 lines 0 comments Download
D chrome/browser/resources/ntp/checkbox_black.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp/checkbox_white.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp/closed_window.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp/drag_drop_controller.js View 1 chunk +0 lines, -212 lines 0 comments Download
chrome/browser/resources/ntp/g-button-chocobo.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp/most_visited.css View 1 chunk +0 lines, -279 lines 0 comments Download
D chrome/browser/resources/ntp/most_visited.js View 1 chunk +0 lines, -713 lines 0 comments Download
D chrome/browser/resources/ntp/ntp_close.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp/ntp_close_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/resources/ntp/ntp_close_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp/ntp_disclosure_triangle.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp/ntp_pin_off.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp/ntp_pin_off_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/resources/ntp/ntp_pin_off_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp/ntp_pin_on.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp/ntp_pin_on_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp/ntp_pin_on_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/ntp4/apps_page.css View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/ntp4/images/app_promo_button.png View Binary file 0 comments Download
A + chrome/browser/resources/ntp4/images/closed_window.png View Binary file 0 comments Download
A + chrome/browser/resources/ntp4/images/disclosure_triangle_mask.png View Binary file 0 comments Download
A + chrome/browser/resources/ntp4/images/trash.png View Binary file 0 comments Download
M chrome/browser/resources/ntp4/new_tab.css View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/ntp4/ntp4_disclosure_triangle_mask.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/ntp4/recently_closed.css View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/resources/ntp4/trash.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
this is a lighter weight version of http://codereview.chromium.org/8036002/ that leaves the code mostly alone, and ...
9 years, 2 months ago (2011-10-18 19:34:55 UTC) #1
Evan Stade
oh right, trybots can't handle binary changes. I'll land this when the tree is quiet.
9 years, 2 months ago (2011-10-18 20:35:22 UTC) #2
Rick Byers
LGTM - thanks!
9 years, 2 months ago (2011-10-18 21:17:11 UTC) #3
Dan Beam
9 years, 2 months ago (2011-10-18 21:40:52 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698