chrome_frame/crash_reporting/crash_metrics.cc - Issue 8344004: base/win: Add documentation to RegKey::Read/Write functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/crash_reporting/crash_metrics.cc

Issue 8344004: base/win: Add documentation to RegKey::Read/Write functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix indentation Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_frame/crash_reporting/crash_metrics.cc

diff --git a/chrome_frame/crash_reporting/crash_metrics.cc b/chrome_frame/crash_reporting/crash_metrics.cc

index 8a103f1e6537bc818ed3bf166e6428d1234f65ad..3630a092f6df00a8792b5d486f15d62bf7de4c07 100644

--- a/chrome_frame/crash_reporting/crash_metrics.cc

+++ b/chrome_frame/crash_reporting/crash_metrics.cc

@@ -54,8 +54,8 @@ int CrashMetricsReporter::GetMetric(Metric metric) {

base::win::RegKey metric_key;

if (metric_key.Open(HKEY_CURRENT_USER, kChromeFrameMetricsKey,

KEY_QUERY_VALUE) == ERROR_SUCCESS) {

- metric_key.ReadValueDW(g_metric_names[metric],

- reinterpret_cast<DWORD*>(&ret));

+ metric_key.ReadValue(g_metric_names[metric],

+ reinterpret_cast<DWORD*>(&ret));

}

return ret;