base/win: Add documentation to RegKey::Read/Write functions.

chrome/installer/util/google_update_settings.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/google_update_settings.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/path_service.h"
@@ skipping 95 matching lines @@
     return true;
   return (key.DeleteValue(name) == ERROR_SUCCESS);
 }
 
 EulaSearchResult HasEULASetting(HKEY root, const std::wstring& state_key,
                                 bool setting) {
   RegKey key;
   DWORD previous_value = setting ? 1 : 0;
   if (key.Open(root, state_key.c_str(), KEY_QUERY_VALUE) != ERROR_SUCCESS)
     return NO_SETTING;
-  if (key.ReadValueDW(google_update::kRegEULAAceptedField,
-                      &previous_value) != ERROR_SUCCESS)
+  if (key.ReadValue(google_update::kRegEULAAceptedField,
+                    &previous_value) != ERROR_SUCCESS)
     return FOUND_CLIENT_STATE;
 
   return ((previous_value != 0) == setting) ?
       FOUND_SAME_SETTING : FOUND_OPPOSITE_SETTING;
 }
 
 bool GetChromeChannelInternal(bool system_install,
                               bool add_multi_modifier,
                               std::wstring* channel) {
   BrowserDistribution* dist = BrowserDistribution::GetDistribution();
@@ skipping 71 matching lines @@
 
   RegKey key;
   DWORD value = 0;
   bool have_value = false;
 
   // For system-level installs, try ClientStateMedium first.
   have_value =
       system_install &&
       key.Open(HKEY_LOCAL_MACHINE, dist->GetStateMediumKey().c_str(),
                KEY_QUERY_VALUE) == ERROR_SUCCESS &&
-      key.ReadValueDW(google_update::kRegUsageStatsField,
-                      &value) == ERROR_SUCCESS;
+      key.ReadValue(google_update::kRegUsageStatsField,
+                    &value) == ERROR_SUCCESS;
 
   // Otherwise, try ClientState.
   have_value =
       !have_value &&
       key.Open(system_install ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER,
                dist->GetStateKey().c_str(), KEY_QUERY_VALUE) == ERROR_SUCCESS &&
-      key.ReadValueDW(google_update::kRegUsageStatsField,
-                      &value) == ERROR_SUCCESS;
+      key.ReadValue(google_update::kRegUsageStatsField,
+                    &value) == ERROR_SUCCESS;
 
   // Google Update specifically checks that the value is 1, so we do the same.
   return have_value && value == 1;
 }
 
 bool GoogleUpdateSettings::SetCollectStatsConsent(bool consented) {
   // Google Update writes and expects 1 for true, 0 for false.
   DWORD value = consented ? 1 : 0;
 
   // Determine whether this is a system-level or a user-level install.
@@ skipping 272 matching lines @@
                       KEY_QUERY_VALUE) == ERROR_SUCCESS) {
     static const size_t kPrefixLen =
         arraysize(kGoogleUpdateUpdateOverrideValuePrefix) - 1;
     DWORD value;
     std::wstring app_update_override;
     app_update_override.reserve(kPrefixLen + app_guid.size());
     app_update_override.append(kGoogleUpdateUpdateOverrideValuePrefix,
                                kPrefixLen);
     app_update_override.append(app_guid);
     // First try to read and comprehend the app-specific override.
-    found_override = (policy_key.ReadValueDW(app_update_override.c_str(),
-                                             &value) == ERROR_SUCCESS &&
+    found_override = (policy_key.ReadValue(app_update_override.c_str(),
+                                           &value) == ERROR_SUCCESS &&
                       GetUpdatePolicyFromDword(value, &update_policy));
 
     // Failing that, try to read and comprehend the default override.
     if (!found_override &&
-        policy_key.ReadValueDW(kGoogleUpdateUpdatePolicyValue,
-                               &value) == ERROR_SUCCESS) {
+        policy_key.ReadValue(kGoogleUpdateUpdatePolicyValue,
+                             &value) == ERROR_SUCCESS) {
       GetUpdatePolicyFromDword(value, &update_policy);
     }
   }
 #endif  // defined(GOOGLE_CHROME_BUILD)
 
   if (is_overridden != NULL)
     *is_overridden = found_override;
 
   return update_policy;
 }