base/win: Add documentation to RegKey::Read/Write functions.

base/win/registry.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/win/registry.h"
 
 #include <shlwapi.h>
 
 #include "base/logging.h"
 #include "base/threading/thread_restrictions.h"
@@ skipping 124 matching lines @@
 }
 
 LONG RegKey::DeleteValue(const wchar_t* value_name) {
   base::ThreadRestrictions::AssertIOAllowed();
   DCHECK(key_);
   DCHECK(value_name);
   LONG result = RegDeleteValue(key_, value_name);
   return result;
 }
 
-LONG RegKey::ReadValue(const wchar_t* name, void* data, DWORD* dsize,
-                       DWORD* dtype) const {
-  base::ThreadRestrictions::AssertIOAllowed();
-  LONG result = RegQueryValueEx(key_, name, 0, dtype,
-                                reinterpret_cast<LPBYTE>(data), dsize);
+LONG RegKey::ReadValueDW(const wchar_t* name, DWORD* out_value) const {

[M-A Ruel, 2011/10/18 18:34:14]

What makes this ordering better than the previous one? It's not sorted by name
or anything. I prefer not to move code 'just to move it' since it breaks svn
blame/git blame.

+  DCHECK(out_value);
+  DWORD type = REG_DWORD;
+  DWORD size = sizeof(DWORD);
+  DWORD local_value = 0;
+  LONG result = ReadValue(name, &local_value, &size, &type);
+  if (result == ERROR_SUCCESS) {
+    if ((type == REG_DWORD || type == REG_BINARY) && size == sizeof(DWORD))
+      *out_value = local_value;
+    else
+      result = ERROR_CANTREAD;
+  }
+
   return result;
 }
 
-LONG RegKey::ReadValue(const wchar_t* name, std::wstring* value) const {
+LONG RegKey::ReadInt64(const wchar_t* name, int64* out_value) const {
+  DCHECK(out_value);
+  DWORD type = REG_QWORD;
+  int64 local_value = 0;
+  DWORD size = sizeof(local_value);
+  LONG result = ReadValue(name, &local_value, &size, &type);
+  if (result == ERROR_SUCCESS) {
+    if ((type == REG_QWORD || type == REG_BINARY) &&
+        size == sizeof(local_value))
+      *out_value = local_value;
+    else
+      result = ERROR_CANTREAD;
+  }
+
+  return result;
+}
+
+LONG RegKey::ReadValue(const wchar_t* name, std::wstring* out_value) const {
   base::ThreadRestrictions::AssertIOAllowed();
-  DCHECK(value);
+  DCHECK(out_value);
   const size_t kMaxStringLength = 1024;  // This is after expansion.
   // Use the one of the other forms of ReadValue if 1024 is too small for you.
   wchar_t raw_value[kMaxStringLength];
   DWORD type = REG_SZ, size = sizeof(raw_value);
   LONG result = ReadValue(name, raw_value, &size, &type);
   if (result == ERROR_SUCCESS) {
     if (type == REG_SZ) {
-      *value = raw_value;
+      *out_value = raw_value;
     } else if (type == REG_EXPAND_SZ) {
       wchar_t expanded[kMaxStringLength];
       size = ExpandEnvironmentStrings(raw_value, expanded, kMaxStringLength);
       // Success: returns the number of wchar_t's copied
       // Fail: buffer too small, returns the size required
       // Fail: other, returns 0
       if (size == 0 || size > kMaxStringLength) {
         result = ERROR_MORE_DATA;
       } else {
-        *value = expanded;
+        *out_value = expanded;
       }
     } else {
       // Not a string. Oops.
       result = ERROR_CANTREAD;
     }
   }
 
   return result;
 }
 
-LONG RegKey::ReadValueDW(const wchar_t* name, DWORD* value) const {
-  DCHECK(value);
-  DWORD type = REG_DWORD;
-  DWORD size = sizeof(DWORD);
-  DWORD local_value = 0;
-  LONG result = ReadValue(name, &local_value, &size, &type);
-  if (result == ERROR_SUCCESS) {
-    if ((type == REG_DWORD || type == REG_BINARY) && size == sizeof(DWORD)) {
-      *value = local_value;
-    } else {
-      result = ERROR_CANTREAD;
-    }
-  }
-
+LONG RegKey::ReadValue(const wchar_t* name,
+                       void* data,
+                       DWORD* dsize,
+                       DWORD* dtype) const {
+  base::ThreadRestrictions::AssertIOAllowed();
+  LONG result = RegQueryValueEx(key_, name, 0, dtype,
+                                reinterpret_cast<LPBYTE>(data), dsize);
   return result;
 }
 
-LONG RegKey::ReadInt64(const wchar_t* name, int64* value) const {
-  DCHECK(value);
-  DWORD type = REG_QWORD;
-  int64 local_value = 0;
-  DWORD size = sizeof(local_value);
-  LONG result = ReadValue(name, &local_value, &size, &type);
-  if (result == ERROR_SUCCESS) {
-    if ((type == REG_QWORD || type == REG_BINARY) &&
-        size == sizeof(local_value)) {
-      *value = local_value;
-    } else {
-      result = ERROR_CANTREAD;
-    }
-  }
-
-  return result;
+LONG RegKey::WriteValue(const wchar_t* name, DWORD in_value) {
+  return WriteValue(
+      name, &in_value, static_cast<DWORD>(sizeof(in_value)), REG_DWORD);
 }
 
-LONG RegKey::WriteValue(const wchar_t* name, const void * data,
-                        DWORD dsize, DWORD dtype) {
+LONG RegKey::WriteValue(const wchar_t * name, const wchar_t* in_value) {
+  return WriteValue(name, in_value,
+      static_cast<DWORD>(sizeof(*in_value) * (wcslen(in_value) + 1)), REG_SZ);
+}
+
+LONG RegKey::WriteValue(const wchar_t* name,
+                        const void* data,
+                        DWORD dsize,
+                        DWORD dtype) {
   base::ThreadRestrictions::AssertIOAllowed();
   DCHECK(data || !dsize);
 
   LONG result = RegSetValueEx(key_, name, 0, dtype,
       reinterpret_cast<LPBYTE>(const_cast<void*>(data)), dsize);
   return result;
 }
 
-LONG RegKey::WriteValue(const wchar_t * name, const wchar_t* value) {
-  return WriteValue(name, value,
-      static_cast<DWORD>(sizeof(*value) * (wcslen(value) + 1)), REG_SZ);
-}
-
-LONG RegKey::WriteValue(const wchar_t* name, DWORD value) {
-  return WriteValue(name, &value, static_cast<DWORD>(sizeof(value)), REG_DWORD);
-}
-
 LONG RegKey::StartWatching() {
   DCHECK(key_);
   if (!watch_event_)
     watch_event_ = CreateEvent(NULL, TRUE, FALSE, NULL);
 
   DWORD filter = REG_NOTIFY_CHANGE_NAME |
                  REG_NOTIFY_CHANGE_ATTRIBUTES |
                  REG_NOTIFY_CHANGE_LAST_SET |
                  REG_NOTIFY_CHANGE_SECURITY;
 
@@ skipping 155 matching lines @@
     if (ERROR_SUCCESS == r)
       return true;
   }
 
   name_[0] = '\0';
   return false;
 }
 
 }  // namespace win
 }  // namespace base