Issue 8343072: Roll webkit 98723:98752

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8343072: Roll webkit 98723:98752 (Closed)

Created:
9 years, 1 month ago by John Gregg

Modified:
9 years, 1 month ago

Reviewers:
eroman

CC:
chromium-reviews, eroman, mmenke, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Roll webkit 98723:98752 TBR=caseq BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107810

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/webui/net_internals_ui_browsertest.cc	View		1 chunk	+5 lines, -4 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

eroman

9 years, 1 month ago (2011-10-28 23:44:19 UTC) #1

http://codereview.chromium.org/8343072/diff/1/chrome/browser/ui/webui/net_int...
File chrome/browser/ui/webui/net_internals_ui_browsertest.cc (right):

http://codereview.chromium.org/8343072/diff/1/chrome/browser/ui/webui/net_int...
chrome/browser/ui/webui/net_internals_ui_browsertest.cc:279:
IN_PROC_BROWSER_TEST_F(NetInternalsTest, FAILS_NetInternalsDnsViewSuccess) {
Is there a bug on file for resolving these?

BTW FAILS_ is not sufficient --> the bots have gone red because of the timeouts.
You will need to DISABLE_ them to prevent it turning red.

Expand Messages | Collapse Messages