Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 8343070: Support dispositon attribute. (Closed)

Created:
9 years, 1 month ago by Greg Billock
Modified:
9 years, 1 month ago
Reviewers:
jam, James Hawkins
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Support dispositon attribute. R=jhawkins@chromium.org BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108042

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change decl order #

Patch Set 3 : Rebase to head #

Patch Set 4 : Try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -43 lines) Patch
M chrome/browser/external_tab_container_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 2 chunks +8 lines, -7 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 4 chunks +17 lines, -15 lines 0 comments Download
M content/browser/tab_contents/tab_contents_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/intents_messages.h View 1 chunk +8 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M webkit/glue/web_intent_service_data.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/web_intent_service_data.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Greg Billock
9 years, 1 month ago (2011-10-28 21:27:01 UTC) #1
James Hawkins
Are you adding the webdb registration code in a followup CL? http://codereview.chromium.org/8343070/diff/1/content/browser/tab_contents/tab_contents.cc File content/browser/tab_contents/tab_contents.cc (right): ...
9 years, 1 month ago (2011-10-28 22:25:36 UTC) #2
Greg Billock
webdb registration is already done; it just wasn't hooked up to anything. I have the ...
9 years, 1 month ago (2011-10-28 23:55:21 UTC) #3
James Hawkins
lgtm
9 years, 1 month ago (2011-10-29 22:27:43 UTC) #4
Greg Billock
On 2011/10/29 22:27:43, James Hawkins wrote: > lgtm John, can you look at this for ...
9 years, 1 month ago (2011-10-31 20:44:56 UTC) #5
jam
lgtm
9 years, 1 month ago (2011-10-31 21:24:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/8343070/31
9 years, 1 month ago (2011-10-31 21:36:06 UTC) #7
commit-bot: I haz the power
Can't apply patch for file content/browser/tab_contents/tab_contents.cc. While running patch -p1 --forward --force; patching file content/browser/tab_contents/tab_contents.cc ...
9 years, 1 month ago (2011-10-31 21:36:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/8343070/8001
9 years, 1 month ago (2011-10-31 22:14:06 UTC) #9
commit-bot: I haz the power
Can't process patch for file content/common/view_messages.h. File's status is None, patchset upload is incomplete.
9 years, 1 month ago (2011-10-31 22:14:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/8343070/4002
9 years, 1 month ago (2011-10-31 22:44:45 UTC) #11
commit-bot: I haz the power
9 years, 1 month ago (2011-10-31 23:56:31 UTC) #12
Change committed as 108042

Powered by Google App Engine
This is Rietveld 408576698