chromeos: Add MockDBusThreadManager and mock clients.

chromeos: Add MockDBusThreadManager and mock clients.

I thought we wouldn't need a mock for this, but I was wrong.
To properly fix crosbug.com/22183, we need to mock out DBusThreadManager.
As always, it's never too late to do the right thing.

BUG=chromium-os:22197
TEST=D-Bus functions work as before (brightness change keys work)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107853

[oshima, 2011-10-28 23:35:20]

http://codereview.chromium.org/8343069/diff/1/chrome/browser/chromeos/dbus/db...
File chrome/browser/chromeos/dbus/dbus_thread_manager.cc (right):

http://codereview.chromium.org/8343069/diff/1/chrome/browser/chromeos/dbus/db...
chrome/browser/chromeos/dbus/dbus_thread_manager.cc:24: class
DBusThreadManagerImpl : public DBusThreadManager {
Not requirement, but I prefer to put class in .cc to be in anonymous name space
to hide it from other files.

http://codereview.chromium.org/8343069/diff/1/chrome/browser/chromeos/dbus/db...
chrome/browser/chromeos/dbus/dbus_thread_manager.cc:49: }
nuke {}

http://codereview.chromium.org/8343069/diff/1/chrome/browser/chromeos/dbus/db...
chrome/browser/chromeos/dbus/dbus_thread_manager.cc:128: // This can happen in
tests.
Given that we now have initialize for test, shouldn't this be CHECK/DCHECK?

http://codereview.chromium.org/8343069/diff/1/chrome/browser/chromeos/dbus/db...
chrome/browser/chromeos/dbus/dbus_thread_manager.cc:141: LOG(WARNING) <<
"DBusThreadManager was already initialized";
If this is expected, please change this to INFO or if you want to keep this
WARNING, make it clear that it's expected.

[satorux1, 2011-10-28 23:43:29]

http://codereview.chromium.org/8343069/diff/1/chrome/browser/chromeos/dbus/db...
File chrome/browser/chromeos/dbus/dbus_thread_manager.cc (right):

http://codereview.chromium.org/8343069/diff/1/chrome/browser/chromeos/dbus/db...
chrome/browser/chromeos/dbus/dbus_thread_manager.cc:49: }
On 2011/10/28 23:35:20, oshima wrote:
> nuke {}

Done.

http://codereview.chromium.org/8343069/diff/1/chrome/browser/chromeos/dbus/db...
chrome/browser/chromeos/dbus/dbus_thread_manager.cc:128: // This can happen in
tests.
On 2011/10/28 23:35:20, oshima wrote:
> Given that we now have initialize for test, shouldn't this be CHECK/DCHECK?

Tests are not yet converted to use InitializeForTesting(). For now, I just
removed the comment from here.

http://codereview.chromium.org/8343069/diff/1/chrome/browser/chromeos/dbus/db...
chrome/browser/chromeos/dbus/dbus_thread_manager.cc:141: LOG(WARNING) <<
"DBusThreadManager was already initialized";
On 2011/10/28 23:35:20, oshima wrote:
> If this is expected, please change this to INFO or if you want to keep this
> WARNING, make it clear that it's expected.

This is not expected. I removed the irrelevant comment, but not brave enough to
make it DCHECK() yet. :)

[oshima, 2011-10-28 23:51:47]

LGTM

http://codereview.chromium.org/8343069/diff/17/chrome/browser/chromeos/dbus/d...
File chrome/browser/chromeos/dbus/dbus_thread_manager.cc (right):

http://codereview.chromium.org/8343069/diff/17/chrome/browser/chromeos/dbus/d...
chrome/browser/chromeos/dbus/dbus_thread_manager.cc:148: // This can happen in
tests.
If this shouldn't happen but not ready to change to DCHECK,  please add TODO to
fix it when ready

[satorux1, 2011-10-28 23:54:35]

http://codereview.chromium.org/8343069/diff/17/chrome/browser/chromeos/dbus/d...
File chrome/browser/chromeos/dbus/dbus_thread_manager.cc (right):

http://codereview.chromium.org/8343069/diff/17/chrome/browser/chromeos/dbus/d...
chrome/browser/chromeos/dbus/dbus_thread_manager.cc:148: // This can happen in
tests.
On 2011/10/28 23:51:47, oshima wrote:
> If this shouldn't happen but not ready to change to DCHECK,  please add TODO
to
> fix it when ready

Done.

[oshima, 2011-10-29 00:05:52]

http://codereview.chromium.org/8343069/diff/5001/chrome/browser/chromeos/dbus...
File chrome/browser/chromeos/dbus/mock_dbus_thread_manager.cc (right):

http://codereview.chromium.org/8343069/diff/5001/chrome/browser/chromeos/dbus...
chrome/browser/chromeos/dbus/mock_dbus_thread_manager.cc:36:
.WillRepeatedly(Return(mock_speech_synthesizer_client_.get()));
Maybe 

DBusThreadManager::InitializeForTesting(this);

here?

[satorux1, 2011-10-29 00:08:10]

http://codereview.chromium.org/8343069/diff/5001/chrome/browser/chromeos/dbus...
File chrome/browser/chromeos/dbus/mock_dbus_thread_manager.cc (right):

http://codereview.chromium.org/8343069/diff/5001/chrome/browser/chromeos/dbus...
chrome/browser/chromeos/dbus/mock_dbus_thread_manager.cc:36:
.WillRepeatedly(Return(mock_speech_synthesizer_client_.get()));
On 2011/10/29 00:05:52, oshima wrote:
> Maybe 
> 
> DBusThreadManager::InitializeForTesting(this);
> 
> here?

I'd rather do it from tests explicitly. Thank you for the suggestion.