Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 8343066: aura: Draw persistent borders around browser windows. (Closed)

Created:
9 years, 1 month ago by Daniel Erat
Modified:
9 years, 1 month ago
Reviewers:
James Cook
CC:
chromium-reviews, oshima
Visibility:
Public.

Description

aura: Draw persistent borders around browser windows. This makes BrowserNonClientFrameViewAura's translucent gray background always stick out a bit beyond the sides and bottom of windows, instead of just peeking out when the user hovers for resizing. I originally added a separate view for this, but it looked strange since Chrome already draws a shadow along the top of the tab strip. BUG=101977 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Daniel Erat
9 years, 1 month ago (2011-10-28 20:17:49 UTC) #1
James Cook
9 years, 1 month ago (2011-10-28 20:41:03 UTC) #2
LGTM

At some point I should correctly compute the top-to-toolbar distance, but that's
my problem not yours. :-)

Powered by Google App Engine
This is Rietveld 408576698