Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 8343062: Quick fix for memory race inherent to all subclasses of base::Thread. (Closed)

Created:
9 years, 1 month ago by Jói
Modified:
9 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, MP, Timur Iskhodzhanov
Visibility:
Public.

Description

Quick fix for memory race inherent to all subclasses of base::Thread. This is a local fix because TSAN is complaining only about this particular case. A follow-up change (which will likely take more time) will make sure this is OK across the code-base. BUG=98716, 102134 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/browser/browser_thread_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jói
9 years, 1 month ago (2011-10-28 16:44:00 UTC) #1
jam
lgtm so I understand: this existed before your change?
9 years, 1 month ago (2011-10-28 16:56:24 UTC) #2
Jói
On 2011/10/28 16:56:24, John Abd-El-Malek wrote: > lgtm > > so I understand: this existed ...
9 years, 1 month ago (2011-10-28 17:02:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8343062/1
9 years, 1 month ago (2011-10-28 17:03:14 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-10-28 18:20:27 UTC) #5
Change committed as 107755

Powered by Google App Engine
This is Rietveld 408576698