Make eval consider anything on the form eval(args...) a potential direct cal

Make eval consider anything on the form eval(args...) a potential direct cal

Previously we omitted all cases where the global eval property was shadowed,
even if by a variable holding the same value. ES5 requires us to treat these
as direct calls.

We still throw if calling indirect eval with a detached global object.

BUG=v8:994
TEST=mjsunit/eval.js

Committed: http://code.google.com/p/v8/source/detail?r=9838

[Rico, 2011-10-31 08:14:56]

LGTM

http://codereview.chromium.org/8343054/diff/1/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/8343054/diff/1/src/v8natives.js#newcode174
src/v8natives.js:174: throw new $EvalError('The "this" value passed to eval must
' +
is object->value intentional, will this make us better compatible with JSC?

http://codereview.chromium.org/8343054/diff/1/test/mjsunit/eval.js
File test/mjsunit/eval.js (right):

http://codereview.chromium.org/8343054/diff/1/test/mjsunit/eval.js#newcode161
test/mjsunit/eval.js:161: var obj1 = { f: function(eval) { return eval("this");
} };
Why the rename to obj1 (and obj2 below)

http://codereview.chromium.org/8343054/diff/1/test/mjsunit/regress/regress-22...
File test/mjsunit/regress/regress-221.js (right):

http://codereview.chromium.org/8343054/diff/1/test/mjsunit/regress/regress-22...
test/mjsunit/regress/regress-221.js:33: assertThrows('for(;;) eval("delete
eval");');
if we actually do not throw this will be a timout, not an error (since we will
run forever)

[Lasse Reichstein, 2011-10-31 09:37:46]

http://codereview.chromium.org/8343054/diff/1/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/8343054/diff/1/src/v8natives.js#newcode174
src/v8natives.js:174: throw new $EvalError('The "this" value passed to eval must
' +
Yes and yes.
The message is bogus now, since that's not what we are checking  (but that was
always the case for a detached global).

http://codereview.chromium.org/8343054/diff/1/test/mjsunit/eval.js
File test/mjsunit/eval.js (right):

http://codereview.chromium.org/8343054/diff/1/test/mjsunit/eval.js#newcode161
test/mjsunit/eval.js:161: var obj1 = { f: function(eval) { return eval("this");
} };
Artifact of rewriting. At some point the var was outside the function. I'll just
make it "obj".

http://codereview.chromium.org/8343054/diff/1/test/mjsunit/regress/regress-22...
File test/mjsunit/regress/regress-221.js (right):

http://codereview.chromium.org/8343054/diff/1/test/mjsunit/regress/regress-22...
test/mjsunit/regress/regress-221.js:33: assertThrows('for(;;) eval("delete
eval");');
This test is pretty meaningless now, so I'll just remove it, instead of
rewriting it to something that doesn't test the original intent anyway.