Sync Promo: Tweak first tabs

Sync Promo: Tweak first tabs

Some small tweaks which tabs we show during first launch:
  - Previously the sync promo was the first tab. Completing the promo would navigate to the original first startup URL. With this change completing the sync promo always navigates to the new tab page.
  - The original first startup URL is now the 2nd tab (and the original 2nd tab is now the 3rd, etc...).
  - If we have more than two tabs then we suppress the welcome page.

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107770

[sky, 2011-10-28 16:05:59]

http://codereview.chromium.org/8343052/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/8343052/diff/1/chrome/browser/ui/browser.cc#ne...
chrome/browser/ui/browser.cc:2959: GURL Browser::GetHomePageForProfile(Profile*
profile) {
I don't think this method makes much sense on Browser. How about moving it to
Profile?

http://codereview.chromium.org/8343052/diff/1/chrome/browser/ui/browser_init.cc
File chrome/browser/ui/browser_init.cc (right):

http://codereview.chromium.org/8343052/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.cc:1313: if (it != startup_urls->end()) {
nit: no {}

[sail, 2011-10-28 17:50:57]

http://codereview.chromium.org/8343052/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/8343052/diff/1/chrome/browser/ui/browser.cc#ne...
chrome/browser/ui/browser.cc:2959: GURL Browser::GetHomePageForProfile(Profile*
profile) {
On 2011/10/28 16:05:59, sky wrote:
> I don't think this method makes much sense on Browser. How about moving it to
> Profile?

Done.

http://codereview.chromium.org/8343052/diff/1/chrome/browser/ui/browser_init.cc
File chrome/browser/ui/browser_init.cc (right):

http://codereview.chromium.org/8343052/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.cc:1313: if (it != startup_urls->end()) {
On 2011/10/28 16:05:59, sky wrote:
> nit: no {}

Done.

[sky, 2011-10-28 17:54:29]

LGTM

[commit-bot: I haz the power, 2011-10-28 18:00:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8343052/5014

[commit-bot: I haz the power, 2011-10-28 19:22:08]

Change committed as 107770