Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 8343044: Extend swigged TestServer to expose port and sync xmpp port to python (Closed)

Created:
9 years, 1 month ago by Nirnimesh
Modified:
9 years, 1 month ago
Reviewers:
dennis_jeffrey
CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey
Visibility:
Public.

Description

Extend swigged TestServer to expose port and sync xmpp port to python To be used with pyauto. Usage: sync_server = pyauto.TestServer(pyauto.TestServer.TYPE_SYNC, pyauto.FilePath(self.DataDir())) sync_server.Start() print sync_server.GetPort(), sync_server.GetSyncXmppPort() sync_server.Stop() R=dennisjeffrey@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107672

Patch Set 1 #

Total comments: 2

Patch Set 2 : added ; #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/test/pyautolib/pyautolib.i View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nirnimesh
9 years, 1 month ago (2011-10-28 00:25:32 UTC) #1
dennis_jeffrey
LGTM http://codereview.chromium.org/8343044/diff/1/chrome/test/pyautolib/pyautolib.i File chrome/test/pyautolib/pyautolib.i (right): http://codereview.chromium.org/8343044/diff/1/chrome/test/pyautolib/pyautolib.i#newcode451 chrome/test/pyautolib/pyautolib.i:451: } nit: is it customary to have a ...
9 years, 1 month ago (2011-10-28 00:33:51 UTC) #2
Nirnimesh
9 years, 1 month ago (2011-10-28 00:40:25 UTC) #3
http://codereview.chromium.org/8343044/diff/1/chrome/test/pyautolib/pyautolib.i
File chrome/test/pyautolib/pyautolib.i (right):

http://codereview.chromium.org/8343044/diff/1/chrome/test/pyautolib/pyautolib...
chrome/test/pyautolib/pyautolib.i:451: }
you're right. added.

Powered by Google App Engine
This is Rietveld 408576698