Issue 8343038: Mark Worker ui layout tests flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8343038: Mark Worker ui layout tests flaky. (Closed)

Created:
9 years, 1 month ago by dmichael (off chromium)

Modified:
9 years, 1 month ago

Reviewers:
dmichael(do not use this one), eroman, rohitrao (ping after 24h)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -7 lines)			Patch
	M	content/worker/test/worker_uitest.cc	View	1 2	3 chunks	+31 lines, -7 lines	0 comments	Download

Total messages: 7 (0 generated)

rohitrao (ping after 24h)

Do other flaky tests use this pattern? I'm used to seeing MAYBE_TestName, where MAYBE_TestName is ...

9 years, 1 month ago (2011-10-27 22:17:26 UTC) #2

eroman

Actually yeah, what rohitrao said. I usually see this as MAYBE_

9 years, 1 month ago (2011-10-27 22:18:49 UTC) #4

dmichael (off chromium)

Okay, I'd mostly seen the other style before (this file has a little of both), ...

9 years, 1 month ago (2011-10-27 22:29:16 UTC) #5

rohitrao (ping after 24h)

9 years, 1 month ago (2011-10-27 22:38:16 UTC) #7

LGTM

Please commit this directly with --force instead of sending it through the
commit queue.