parser.dart - Issue 8343037: Throw FallThroughError when we fall through a case in a switch statement. Fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: parser.dart

Issue 8343037: Throw FallThroughError when we fall through a case in a switch statement. Fixes (Closed) Base URL: http://dart.googlecode.com/svn/experimental/frog/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: parser.dart

===================================================================

--- parser.dart (revision 910)

+++ parser.dart (working copy)

@@ -619,6 +619,8 @@

_peekCaseEnd() {

var kind = _peek();

+ //TODO(efortuna): also if the first is an identifier followed by a colon, we

+ //have a label for the case statement.

return kind == TokenKind.RBRACE || kind == TokenKind.CASE ||

kind == TokenKind.DEFAULT;

}

@@ -627,8 +629,8 @@

int start = _peekToken.start;

var label = null;

if (_peekIdentifier()) {

+ label = identifier();

jimhug 2011/10/28 20:02:44 Whoa! How was this working before?

_eat(TokenKind.COLON);

- label = identifier();

}

var cases = [];

while (true) {

« gen.dart ('K') | « lib/corelib.dart ('k') | tests/frog/frog.status » ('j') | tree.dart » ('J')