Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 8343036: Update native_textfield_win.cc to parallel previous changes to omnibox_view_win.cc. (Closed)

Created:
9 years, 1 month ago by Peter Kasting
Modified:
9 years, 1 month ago
Reviewers:
James Hawkins
CC:
chromium-reviews, tfarina, James Su, dhollowa
Visibility:
Public.

Description

Update native_textfield_win.cc to parallel previous changes to omnibox_view_win.cc. BUG=101938 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M views/controls/textfield/native_textfield_win.cc View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
9 years, 1 month ago (2011-10-27 21:14:10 UTC) #1
James Hawkins
Should we find a place higher up in the class chain to share this functionality? ...
9 years, 1 month ago (2011-10-27 21:36:05 UTC) #2
Peter Kasting
On 2011/10/27 21:36:05, James Hawkins wrote: > Should we find a place higher up in ...
9 years, 1 month ago (2011-10-27 21:39:10 UTC) #3
James Hawkins
9 years, 1 month ago (2011-10-27 21:42:28 UTC) #4
On 2011/10/27 21:39:10, Peter Kasting wrote:
> On 2011/10/27 21:36:05, James Hawkins wrote:
> > Should we find a place higher up in the class chain to share this
> functionality?
> >  I don't know if that would involve creating a new class in the hierarchy
just
> > for this (which would seem like too much).
> 
> There's a longstanding issue that native_textfield_win and omnibox_view_win
are
> partial copies of each other (omnibox_view_win is mostly a superset of
> native_textfield_win but not completely).  We've never figured out how to
> resolve this terribly well.  I don't have a good answer for it now either.

That's fine; just wanted to make sure.  LGTM

Powered by Google App Engine
This is Rietveld 408576698