Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 8343033: Add CHECK to catch places where BrowserProcessImpl's refcount goes to 0. (Closed)

Created:
9 years, 1 month ago by willchan no longer on Chromium
Modified:
9 years, 1 month ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews, sadrul, brettw-cc_chromium.org
Visibility:
Public.

Description

Add CHECK to catch places where BrowserProcessImpl's refcount goes to 0. Specifically, catch it when MessageLoop is not running. BUG=96847 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108177

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M base/message_loop.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/message_loop.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
willchan no longer on Chromium
I'm not sure if the tryjobs will fail on me (I think it's likely that ...
9 years, 1 month ago (2011-10-27 20:27:05 UTC) #1
Miranda Callahan
On 2011/10/27 20:27:05, willchan wrote: > I'm not sure if the tryjobs will fail on ...
9 years, 1 month ago (2011-10-27 20:32:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/willchan@chromium.org/8343033/1
9 years, 1 month ago (2011-11-01 20:28:40 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-01 22:07:00 UTC) #4
Change committed as 108177

Powered by Google App Engine
This is Rietveld 408576698