Issue 8343030: MIPS: Fixing performance regression in issue 1787.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8343030: MIPS: Fixing performance regression in issue 1787. (Closed)

Created:
9 years, 1 month ago by kisg

Modified:
9 years, 1 month ago

Reviewers:
Yang, danno

CC:
v8-dev

Visibility:
Public.

Description

MIPS: Fixing performance regression in issue 1787. Port r9812 (c1644a9d) Note: MIPS already had the fix for this regression. This commit only adds the extra assertions. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9827

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/mips/code-stubs-mips.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2011/10/27 20:53:17, kisg wrote: LGTM and thank you for this patch! However, I'm obligated ...

9 years, 1 month ago (2011-10-28 07:55:02 UTC) #2

Yang

9 years, 1 month ago (2011-10-28 08:01:43 UTC) #3

On 2011/10/28 07:55:02, Yang wrote:
> On 2011/10/27 20:53:17, kisg wrote:
> 
> LGTM and thank you for this patch! However, I'm obligated to ask you to sign
the
> CLA (electronically) before I can commit this patch for you:
> http://code.google.com/legal/individual-cla-v1.0.html

Never mind the CLA. Landing... :)

Expand Messages | Collapse Messages