Add license check suppression for EGL extension header

Add license check suppression for EGL extension header

Add a license check suppression for gpu/EGL/eglext.h which got added in a
recent commit. This is temporary fix and will be remedied by moving all the
Khronos headers under gpu to third_party -- See
http://code.google.com/p/chromium/issues/detail?id=98097.

BUG=98097
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107641

[Lei Zhang, 2011-10-27 19:38:47]

lgtm

[commit-bot: I haz the power, 2011-10-27 20:33:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyostil@google.com/8343028/1

[commit-bot: I haz the power, 2011-10-27 22:46:23]

Change committed as 107641

[Paweł Hajdan Jr., 2011-10-28 08:25:48]

I'm not sure what your plans are, but moving the code does not change anything.
All code in the tree should have recognized licenses, no matter where it is
located.

[Paweł Hajdan Jr., 2011-10-28 08:50:57]

By the way, I just noticed that the code in question has a license header, but
we don't recognize it.

Please follow instructions at
http://www.chromium.org/developers/adding-3rd-party-libraries and make
third_party/devscripts/licensecheck.pl recognize the license, and remove the
suppression.

Or, you can just tell me what the license is and what the regex is, and I'll
handle things for you.

Please do it very shortly, we shouldn't be accumulating new suppressions and the
page I linked to mentions reverts.

Feel free to ping me on irc, IM or e-mail and I'd be very happy to help you. Noe
I'm now in GMT+2.

[Sami, 2011-10-31 11:06:06]

Right, I should have been a little clearer about what I was planning. I was
going to both move the headers under third_party and make sure the license check
tools detect the Khronos license correctly. These header files are under an MIT
license.

Sorry I couldn't sort this out earlier, but I'll try to get it done within the
next few days.

On 2011/10/28 08:50:57, Paweł Hajdan Jr. wrote:
> By the way, I just noticed that the code in question has a license header, but
> we don't recognize it.
> 
> Please follow instructions at
> http://www.chromium.org/developers/adding-3rd-party-libraries and make
> third_party/devscripts/licensecheck.pl recognize the license, and remove the
> suppression.
> 
> Or, you can just tell me what the license is and what the regex is, and I'll
> handle things for you.
> 
> Please do it very shortly, we shouldn't be accumulating new suppressions and
the
> page I linked to mentions reverts.
> 
> Feel free to ping me on irc, IM or e-mail and I'd be very happy to help you.
Noe
> I'm now in GMT+2.

[Paweł Hajdan Jr., 2011-11-02 08:37:36]

On Mon, Oct 31, 2011 at 12:06, <skyostil@chromium.org> wrote:

> Right, I should have been a little clearer about what I was planning. I was
> going to both move the headers under third_party and make sure the license
> check
> tools detect the Khronos license correctly.


This sounds good to me. Could you please make this the very first thing you
do? Generally you're expected to fix this before landing.


> These header files are under an MIT license.
>

Right, the checker has a very similar regex now:

    } elsif ($licensetext =~ /Permission is hereby granted, free of charge,
to any person obtaining a copy of this software and associated
documentation files \(the Software\), to deal in the Software/) {
        $license = "MIT/X11 (BSD like) $license";
    }

You should be able to update it to also accept the "Materials" wording, and
"and/or" part. It shouldn't be too hard.


> Sorry I couldn't sort this out earlier, but I'll try to get it done within
> the
> next few days.


No problem, just please do it. I could do it but it doesn't always scale
well.


>
>
> On 2011/10/28 08:50:57, Paweł Hajdan Jr. wrote:
>
>> By the way, I just noticed that the code in question has a license
>> header, but
>> we don't recognize it.
>>
>
>  Please follow instructions at
>>
http://www.chromium.org/**developers/adding-3rd-party-**libraries<http://www....
make
>> third_party/devscripts/license**check.pl <http://licensecheck.pl>recognize
the license, and remove the
>> suppression.
>>
>
>  Or, you can just tell me what the license is and what the regex is, and
>> I'll
>> handle things for you.
>>
>
>  Please do it very shortly, we shouldn't be accumulating new suppressions
>> and
>>
> the
>
>> page I linked to mentions reverts.
>>
>
>  Feel free to ping me on irc, IM or e-mail and I'd be very happy to help
>> you.
>>
> Noe
>
>> I'm now in GMT+2.
>>
>
>
>
>
http://codereview.chromium.**org/8343028/<http://codereview.chromium.org/8343...
>

[Sami, 2011-11-02 10:37:17]

Just to give a status update, I've got the license recognition sorted out and
now I'm correcting the references to the headers from all around the source
tree.