Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8343023: rename Run in MessageLoopForUI to RunWithDispatcher (Closed)

Created:
9 years, 2 months ago by oshima
Modified:
9 years, 2 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, scherkus (not reviewing), ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, brettw-cc_chromium.org, jam, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), Paweł Hajdan Jr., ajwong+watch_chromium.org, pam+watch_chromium.org, James Su, dhollowa, tfarina, ihf+watch_chromium.org
Visibility:
Public.

Description

rename Run in MessageLoopForUI to RunWithDispatcher BUG=99471 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106896

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -38 lines) Patch
M base/message_loop.h View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/simple_message_box_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/user_data_dir_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/chrome_frame_automation_mock.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/browser_main.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/desktop.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ui/aura/desktop.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/nested_dispatcher_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/desktop/desktop_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/examples/examples_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/focus/focus_manager_unittest.cc View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M views/widget/native_widget_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
oshima
darin -> please review all files. sky -> OWNERS in ui/, views/, chrome/browser/ui/, chrome/browser/autocomplete/, and ...
9 years, 2 months ago (2011-10-19 14:01:58 UTC) #1
sky
LGTM
9 years, 2 months ago (2011-10-19 15:56:45 UTC) #2
scherkus (not reviewing)
media LGTM -- but that tool should actually be removed from chromium haha
9 years, 2 months ago (2011-10-19 17:17:21 UTC) #3
darin (slow to review)
LGTM
9 years, 2 months ago (2011-10-19 17:26:32 UTC) #4
oshima
I still need LGTM from chrome_frame/ ananta, tommi, amit, robert, can one of you review ...
9 years, 2 months ago (2011-10-19 22:28:54 UTC) #5
amit
lgtm
9 years, 2 months ago (2011-10-19 23:00:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8343023/5001
9 years, 2 months ago (2011-10-19 23:01:28 UTC) #7
commit-bot: I haz the power
Can't apply patch for file content/browser/renderer_host/render_widget_host_view_aura.cc. While running patch -p1 --forward --force; patching file content/browser/renderer_host/render_widget_host_view_aura.cc ...
9 years, 2 months ago (2011-10-19 23:01:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8343023/13001
9 years, 2 months ago (2011-10-22 23:26:52 UTC) #9
commit-bot: I haz the power
Failed to send try job 8343023-13001: 2
9 years, 2 months ago (2011-10-22 23:27:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8343023/13001
9 years, 2 months ago (2011-10-23 00:04:05 UTC) #11
commit-bot: I haz the power
Failed to send try job 8343023-13001: 2
9 years, 2 months ago (2011-10-23 00:04:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8343023/13001
9 years, 2 months ago (2011-10-23 03:55:32 UTC) #13
commit-bot: I haz the power
Failed to send try job 8343023-13001: 2
9 years, 2 months ago (2011-10-23 03:55:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8343023/13001
9 years, 2 months ago (2011-10-23 09:23:46 UTC) #15
commit-bot: I haz the power
9 years, 2 months ago (2011-10-23 09:23:55 UTC) #16 
Failed to send try job 8343023-13001: 2

Powered by Google App Engine
This is Rietveld 408576698