Print Preview: Hiding margins UI if an error occurs.

chrome/browser/resources/print_preview/preview_area.js

Index: chrome/browser/resources/print_preview/preview_area.js
diff --git a/chrome/browser/resources/print_preview/preview_area.js b/chrome/browser/resources/print_preview/preview_area.js
index 5154cc223cefcaa817aef9f29f0ea71e43279da2..b7be7d30500891050f8ced252bc2601b0bb90cea 100644
--- a/chrome/browser/resources/print_preview/preview_area.js
+++ b/chrome/browser/resources/print_preview/preview_area.js
@@ -199,7 +199,6 @@ cr.define('print_preview', function() {
      * @param {string} errorMessage The error message to be displayed.
      */
     displayErrorMessage: function(errorMessage) {

[Evan Stade, 2011/10/19 22:34:11]

this function should be renamed and the doc should be updated as it is doing
more than simple display now.

[dpapad, 2011/10/19 22:56:21]

Done. Temporarily though. I am planning to move the displayMessage logic within
listeners of error events instead of firing such an event from here.

-      $('print-button').disabled = true;
       this.overlayLayer.classList.remove('invisible');
       this.customMessage_.textContent = errorMessage;
       this.customMessage_.hidden = false;
@@ -209,6 +208,7 @@ cr.define('print_preview', function() {
         $('mainview').removeChild(this.pdfPlugin_);
         this.pdfPlugin_ = null;
       }
+      cr.dispatchSimpleEvent(document, 'errorOccurred');

[Evan Stade, 2011/10/19 20:01:55]

i'd like to see a more descriptive event name. What class of error?

[dpapad, 2011/10/19 22:31:59]

Done.

     },
 
     /**