Print Preview: Hiding margins UI if an error occurs.

chrome/browser/resources/print_preview/print_preview.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: cr/ui/print_preview_cloud.js
 
 var localStrings = new LocalStrings();
 
 // If useCloudPrint is true we attempt to connect to cloud print
 // and populate the list of printers with cloud print printers.
@@ skipping 96 matching lines @@
  * Window onload handler, sets up the page and starts print preview by getting
  * the printer list.
  */
 function onLoad() {
   cr.enablePlatformSpecificCSSRules();
   initialPreviewRequestID = randomInteger(MIN_REQUEST_ID, MAX_REQUEST_ID);
   lastPreviewRequestID = initialPreviewRequestID;
 
   previewArea = print_preview.PreviewArea.getInstance();
   printHeader = print_preview.PrintHeader.getInstance();
+  addEventListeners();
 
   if (!checkCompatiblePluginExists()) {
     disableInputElementsInSidebar();
     previewArea.displayErrorMessageWithButton(
         localStrings.getString('noPlugin'),
         localStrings.getString('launchNativeDialog'),
         launchNativePrintDialog);
-    cancelPendingPrintRequest();
     $('mainview').parentElement.removeChild($('dummy-viewer'));
     return;
   }
 
   $('system-dialog-link').addEventListener('click', onSystemDialogLinkClicked);
   $('mainview').parentElement.removeChild($('dummy-viewer'));
 
   $('printer-list').disabled = true;
 
   pageSettings = print_preview.PageSettings.getInstance();
   copiesSettings = print_preview.CopiesSettings.getInstance();
   layoutSettings = print_preview.LayoutSettings.getInstance();
   marginSettings = print_preview.MarginSettings.getInstance();
   headerFooterSettings = print_preview.HeaderFooterSettings.getInstance();
   colorSettings = print_preview.ColorSettings.getInstance();
   $('printer-list').onchange = updateControlsWithSelectedPrinterCapabilities;
 
   previewArea.showLoadingAnimation();
   chrome.send('getInitiatorTabTitle');
   chrome.send('getDefaultPrinter');
 }
 
 /**
+ * Adds event listeners for various events.
+ */
+function addEventListeners() {
+  document.addEventListener('errorOccurred', onErrorOccurred);

[Evan Stade, 2011/10/19 22:34:11]

why does this have its own helper function? at this point I'd inline it as it's
only one line and only move to a helper if it's like 20 lines

[dpapad, 2011/10/19 22:56:21]

Done.

+}
+
+/**
+ * Executes when an 'errorOccurred' event occurs.
+ */
+function onErrorOccurred() {

[Evan Stade, 2011/10/19 22:34:11]

likewise, move the body of cancelpendingprintrequest here

[dpapad, 2011/10/19 22:56:21]

Done.

+  cancelPendingPrintRequest();
+}
+
+/**
  * Disables the input elements in the sidebar.
  */
 function disableInputElementsInSidebar() {
   var els = $('sidebar').querySelectorAll('input, button, select');
   for (var i = 0; i < els.length; i++) {
     if (els[i] == printHeader.cancelButton)
       continue;
     els[i].disabled = true;
   }
 }
@@ skipping 30 matching lines @@
  * data. This function is called when the initiator tab has crashed.
  * @param {string} initiatorTabURL The URL of the initiator tab.
  */
 function onInitiatorTabCrashed(initiatorTabURL) {
   disableInputElementsInSidebar();
   if (initiatorTabURL) {
     previewArea.displayErrorMessageWithButton(
         localStrings.getString('initiatorTabCrashed'),
         localStrings.getString('reopenPage'),
         function() { chrome.send('reloadCrashedInitiatorTab'); });
-    cancelPendingPrintRequest();
   } else {
     previewArea.displayErrorMessage(
         localStrings.getString('initiatorTabCrashed'));
-    cancelPendingPrintRequest();
   }
 }
 
 /**
  * Disables the controls which need the initiator tab to generate preview
  * data. This function is called when the initiator tab is closed.
  * @param {string} initiatorTabURL The URL of the initiator tab.
  */
 function onInitiatorTabClosed(initiatorTabURL) {
   disableInputElementsInSidebar();
   if (initiatorTabURL) {
     previewArea.displayErrorMessageWithButton(
         localStrings.getString('initiatorTabClosed'),
         localStrings.getString('reopenPage'),
         function() { window.location = initiatorTabURL; });
-    cancelPendingPrintRequest();
   } else {
     previewArea.displayErrorMessage(
         localStrings.getString('initiatorTabClosed'));
-    cancelPendingPrintRequest();
   }
 }
 
 /**
  * Gets the selected printer capabilities and updates the controls accordingly.
  */
 function updateControlsWithSelectedPrinterCapabilities() {
   var printerList = $('printer-list');
   var selectedIndex = printerList.selectedIndex;
   if (selectedIndex < 0)
@@ skipping 478 matching lines @@
 
 /**
  * Display an error message when print preview fails.
  * Called from PrintPreviewMessageHandler::OnPrintPreviewFailed().
  */
 function printPreviewFailed() {
   previewArea.displayErrorMessageWithButton(
       localStrings.getString('previewFailed'),
       localStrings.getString('launchNativeDialog'),
       launchNativePrintDialog);
-  cancelPendingPrintRequest();
 }
 
 /**
  * Display an error message when encountered invalid printer settings.
  * Called from PrintPreviewMessageHandler::OnInvalidPrinterSettings().
  */
 function invalidPrinterSettings() {
   previewArea.displayErrorMessage(
       localStrings.getString('invalidPrinterSettings'));
-  cancelPendingPrintRequest();
 }
 
 /**
  * Called when the PDF plugin loads its document.
  */
 function onPDFLoad() {
   if (previewModifiable) {
     setPluginPreviewPageCount();
   }
   cr.dispatchSimpleEvent(document, 'PDFLoaded');
@@ skipping 331 matching lines @@
 <include src="copies_settings.js"/>
 <include src="header_footer_settings.js"/>
 <include src="layout_settings.js"/>
 <include src="color_settings.js"/>
 <include src="margin_settings.js"/>
 <include src="margin_textbox.js"/>
 <include src="margin_utils.js"/>
 <include src="margins_ui.js"/>
 <include src="margins_ui_pair.js"/>
 <include src="preview_area.js"/>