Print Preview: Hiding margins UI if an error occurs.

chrome/browser/resources/print_preview/preview_area.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'strict';
 
   /**
    * Creates a PreviewArea object. It represents the area where the preview
    * document is displayed.
@@ skipping 180 matching lines @@
       this.customMessageWithDots_.hidden = false;
       if (this.pdfPlugin_)
         this.pdfPlugin_.classList.add('invisible');
       this.overlayLayer.classList.remove('invisible');
     },
 
     /**
      * Display an error message in the center of the preview area.
      * @param {string} errorMessage The error message to be displayed.
      */
     displayErrorMessage: function(errorMessage) {

[Evan Stade, 2011/10/19 22:34:11]

this function should be renamed and the doc should be updated as it is doing
more than simple display now.

[dpapad, 2011/10/19 22:56:21]

Done. Temporarily though. I am planning to move the displayMessage logic within
listeners of error events instead of firing such an event from here.

-      $('print-button').disabled = true;
       this.overlayLayer.classList.remove('invisible');
       this.customMessage_.textContent = errorMessage;
       this.customMessage_.hidden = false;
       this.customMessageWithDots_.innerHTML = '';
       this.customMessageWithDots_.hidden = true;
       if (this.pdfPlugin_) {
         $('mainview').removeChild(this.pdfPlugin_);
         this.pdfPlugin_ = null;
       }
+      cr.dispatchSimpleEvent(document, 'errorOccurred');

[Evan Stade, 2011/10/19 20:01:55]

i'd like to see a more descriptive event name. What class of error?

[dpapad, 2011/10/19 22:31:59]

Done.

     },
 
     /**
      * Display an error message in the center of the preview area followed by a
      * button.
      * @param {string} errorMessage The error message to be displayed.
      * @param {string} buttonText The text to be displayed within the button.
      * @param {string} buttonListener The listener to be executed when the
      *     button is clicked.
      */
     displayErrorMessageWithButton: function(
         errorMessage, buttonText, buttonListener) {
       this.errorButton.disabled = false;
       this.errorButton.textContent = buttonText;
       this.errorButton.onclick = buttonListener;
       this.errorButton.hidden = false;
       $('system-dialog-throbber').hidden = true;
       $('native-print-dialog-throbber').hidden = true;
       this.displayErrorMessage(errorMessage);
     }
   };
 
   return {
     PreviewArea: PreviewArea,
   };
 });