Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: client/testing/unittest/unittestsuite.dart

Issue 8343009: Clean up UnitTestSuite a bit. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/testing/unittest/unittestsuite.dart
diff --git a/client/testing/unittest/unittestsuite.dart b/client/testing/unittest/unittestsuite.dart
index a1057c818fcb786a3df6b264db53cd4d3d512d57..d5ad381e765763b03c581ce0bfc3fe07d2605bc5 100644
--- a/client/testing/unittest/unittestsuite.dart
+++ b/client/testing/unittest/unittestsuite.dart
@@ -89,7 +89,7 @@ class UnitTestSuite {
void setUpTestSuite() {}
/** Enqueues a synchronous test. */
- UnitTestSuite addTest(TestFunction body) {
+ void addTest(TestFunction body) {
test(null, body);
}
@@ -290,7 +290,7 @@ void asyncTest(String spec, int callbacks, TestFunction body) {
_ensureActiveSuite();
final testCase = new TestCase(
- _currentSuite._tests.length + 1, _fullSpec(spec), body, callbacks);
+ _currentSuite._tests.length + 1, _fullSpec(spec), body, callbacks);
_currentSuite._tests.add(testCase);
if (callbacks < 1) {
@@ -347,11 +347,10 @@ String _fullSpec(String spec) {
*/
_ensureActiveSuite() {
if (_currentSuite != null) {
- return false;
+ return;
}
_currentSuite = new UnitTestSuite();
- return true;
}
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698