Issue 8343008: base::Bind conversion for chrome/browser/extensions/file_reader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8343008: base::Bind conversion for chrome/browser/extensions/file_reader. (Closed)

Created:
9 years, 2 months ago by adamk

Modified:
9 years, 1 month ago

Reviewers:
aa

CC:
chromium-reviews, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, Erik does not do reviews, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Paweł Hajdan Jr., ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base::Bind conversion for chrome/browser/extensions/file_reader. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108553

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -32 lines)			Patch
M	chrome/browser/chromeos/accessibility_util.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/execute_code_in_tab_function.cc	View	5 chunks	+9 lines, -11 lines	0 comments	Download
M	chrome/browser/extensions/file_reader.h	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/file_reader.cc	View	2 chunks	+5 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/file_reader_unittest.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adamk

Friendly ping (no urgency, just trying to get the spreadsheet synced to reality)

9 years, 2 months ago (2011-10-20 16:35:06 UTC) #2

lgtm

Expand Messages | Collapse Messages