Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 8343001: RegExpMacroAssembler::CheckStackGuardState should update input string pointer (Closed)

Created:
9 years, 2 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 2 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

RegExpMacroAssembler::CheckStackGuardState should update input string pointer when it is moved or changed by GC. If input string was cons-string it might undergo short-circuiting during GC. This does not change input start if underlying seq-string (first element of cons-string) does not move but this makes input-string pointer on the native regexp's frame invalid. R=lrn@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=9697

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/arm/regexp-macro-assembler-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 2 months ago (2011-10-18 16:46:11 UTC) #1
Lasse Reichstein
9 years, 2 months ago (2011-10-19 07:40:04 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698