Add unit tests for about:tracing TimelineModel.

Add unit tests for about:tracing TimelineModel.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106842

[nduca, 2011-10-21 05:37:52]

Quick one. Talked to scr@ about getting these tests running as part of bots.
Will stick to jstest style for the time being.

[jbates, 2011-10-21 16:52:21]

On 2011/10/21 05:37:52, nduca wrote:
> Quick one. Talked to scr@ about getting these tests running as part of bots.
> Will stick to jstest style for the time being.

LGTM

[arv (Not doing code reviews), 2011-10-21 17:09:18]

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
File chrome/browser/resources/tracing/timeline_model.js (right):

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
chrome/browser/resources/tracing/timeline_model.js:157: for (var p in
this.threads)
Missing {}

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
chrome/browser/resources/tracing/timeline_model.js:174: function
getStringHash(name) {
This looks like it might be overkill for choosing colors.

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
chrome/browser/resources/tracing/timeline_model.js:279:
.getOrCreateThread(event.tid);
binop before newline

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
File chrome/browser/resources/tracing/timeline_model_test.html (right):

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
chrome/browser/resources/tracing/timeline_model_test.html:23:
{'name':'a','args':{},'pid':52,'ts':9524,'cat':'foo','tid':53,'ph':'B'},
space after :

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
chrome/browser/resources/tracing/timeline_model_test.html:68: assertEquals((4-1)
/ 1000, slice.duration);
whitespace

[nduca, 2011-10-21 19:50:40]

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
File chrome/browser/resources/tracing/timeline_model.js (right):

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
chrome/browser/resources/tracing/timeline_model.js:157: for (var p in
this.threads)
On 2011/10/21 17:09:18, arv wrote:
> Missing {}

Done.

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
chrome/browser/resources/tracing/timeline_model.js:174: function
getStringHash(name) {
On 2011/10/21 17:09:18, arv wrote:
> This looks like it might be overkill for choosing colors.

Do you have any suggestions? The goal is to get a hash for a string that is
fairly random but also stable across computers --- this way "that red task"
shows up as red on your and my computer. Tracing has been using this one for a
few months and it seems good-ish.

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
chrome/browser/resources/tracing/timeline_model.js:279:
.getOrCreateThread(event.tid);
On 2011/10/21 17:09:18, arv wrote:
> binop before newline

Done.

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
File chrome/browser/resources/tracing/timeline_model_test.html (right):

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
chrome/browser/resources/tracing/timeline_model_test.html:23:
{'name':'a','args':{},'pid':52,'ts':9524,'cat':'foo','tid':53,'ph':'B'},
On 2011/10/21 17:09:18, arv wrote:
> space after :

Done.

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
chrome/browser/resources/tracing/timeline_model_test.html:68: assertEquals((4-1)
/ 1000, slice.duration);
On 2011/10/21 17:09:18, arv wrote:
> whitespace

Done.

[arv (Not doing code reviews), 2011-10-21 23:43:53]

lgtm

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
File chrome/browser/resources/tracing/timeline_model.js (right):

http://codereview.chromium.org/8342069/diff/5001/chrome/browser/resources/tra...
chrome/browser/resources/tracing/timeline_model.js:174: function
getStringHash(name) {
On 2011/10/21 19:50:40, nduca wrote:
> On 2011/10/21 17:09:18, arv wrote:
> > This looks like it might be overkill for choosing colors.
> 
> Do you have any suggestions? The goal is to get a hash for a string that is
> fairly random but also stable across computers --- this way "that red task"
> shows up as red on your and my computer. Tracing has been using this one for a
> few months and it seems good-ish.

I don't have any better idea. Are the strings short? If not maybe limit the
number of chars you go through.