Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: printing/print_settings.h

Issue 8342059: Clarify that the custom margin value is not validated and add tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « printing/page_setup_unittest.cc ('k') | printing/print_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/print_settings.h
diff --git a/printing/print_settings.h b/printing/print_settings.h
index 31417de288fbb9c3901578c6c3652407d1e777bb..07d2c544b229e92fb72042d0547cb512984f4f5b 100644
--- a/printing/print_settings.h
+++ b/printing/print_settings.h
@@ -41,7 +41,7 @@ class PRINTING_EXPORT PrintSettings {
gfx::Rect const& printable_area_device_units,
int units_per_inch);
- void SetCustomMargins(const PageMargins& margins_in_points);
+ void SetCustomMargins(const PageMargins& requested_margins_in_points);
// Equality operator.
// NOTE: printer_name is NOT tested for equality since it doesn't affect the
@@ -139,8 +139,8 @@ class PRINTING_EXPORT PrintSettings {
// True if this printer supports AlphaBlend.
bool supports_alpha_blend_;
- // If margin type is custom, these are the margins.
- PageMargins custom_margins_in_points_;
+ // If margin type is custom, this is what was requested.
+ PageMargins requested_custom_margins_in_points_;
};
} // namespace printing
« no previous file with comments | « printing/page_setup_unittest.cc ('k') | printing/print_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698