Clarify that the custom margin value is not validated and add tests.

printing/print_settings.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/print_settings.h"
 
 #include "base/atomic_sequence_num.h"
 #include "base/logging.h"
 #include "printing/print_job_constants.h"
 #include "printing/units.h"
@@ skipping 166 matching lines @@
       margins.footer = 0;
       margins.top = 0;
       margins.bottom = 0;
       margins.left = 0;
       margins.right = 0;
       break;
     }
     case CUSTOM_MARGINS: {
       margins.header = 0;
       margins.footer = 0;
-      margins.top = ConvertUnitDouble(custom_margins_in_points_.top,
-                                      kPointsPerInch,
-                                      units_per_inch);
-      margins.bottom = ConvertUnitDouble(custom_margins_in_points_.bottom,
-                                         kPointsPerInch,
-                                         units_per_inch);
-      margins.left = ConvertUnitDouble(custom_margins_in_points_.left,
-                                       kPointsPerInch,
-                                       units_per_inch);
-      margins.right = ConvertUnitDouble(custom_margins_in_points_.right,
-                                        kPointsPerInch,
-                                        units_per_inch);
+      margins.top = ConvertUnitDouble(
+          requested_custom_margins_in_points_.top,
+          kPointsPerInch,
+          units_per_inch);
+      margins.bottom = ConvertUnitDouble(
+          requested_custom_margins_in_points_.bottom,
+          kPointsPerInch,
+          units_per_inch);
+      margins.left = ConvertUnitDouble(
+          requested_custom_margins_in_points_.left,
+          kPointsPerInch,
+          units_per_inch);
+      margins.right = ConvertUnitDouble(
+          requested_custom_margins_in_points_.right,
+          kPointsPerInch,
+          units_per_inch);
       break;
     }
     default: {
       NOTREACHED();
     }
   }
 
   if (margin_type == DEFAULT_MARGINS || margin_type == PRINTABLE_AREA_MARGINS)
     page_setup_device_units_.SetRequestedMargins(margins);
   else
     page_setup_device_units_.ForceRequestedMargins(margins);
 }
 
-void PrintSettings::SetCustomMargins(const PageMargins& margins_in_points) {
-  custom_margins_in_points_ = margins_in_points;
+void PrintSettings::SetCustomMargins(
+    const PageMargins& requested_margins_in_points) {
+  requested_custom_margins_in_points_ = requested_margins_in_points;
   margin_type = CUSTOM_MARGINS;
 }
 
 bool PrintSettings::Equals(const PrintSettings& rhs) const {
   // Do not test the display device name (printer_name_) for equality since it
   // may sometimes be chopped off at 30 chars. As long as device_name is the
   // same, that's fine.
   return ranges == rhs.ranges &&
       min_shrink == rhs.min_shrink &&
       max_shrink == rhs.max_shrink &&
@@ skipping 10 matching lines @@
 }
 
 void PrintSettings::SetOrientation(bool landscape) {
   if (landscape_ != landscape) {
     landscape_ = landscape;
     page_setup_device_units_.FlipOrientation();
   }
 }
 
 }  // namespace printing