net: enable CRL sets behind a command line flag.

chrome/browser/net/crl_set_fetcher.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/crl_set_fetcher.h"
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/rand_util.h"
 #include "base/time.h"
@@ skipping 104 matching lines @@
     LOG(WARNING) << "Refusing to downgrade CRL set from #"
                  << old_crl_set->sequence()
                  << "to #"
                  << crl_set->sequence();
   } else {
     net::SSLConfigService::SetCRLSet(crl_set);
     VLOG(1) << "Installed CRL set #" << crl_set->sequence();
   }
 }
 
-// TODO(agl): this is a key for testing only. Replace with a real key.
 static const uint8 kPublicKeySHA256[32] = {

[wtc, 2011/10/21 23:17:31]

Nit: document whose public key this is.

[agl, 2011/10/24 20:44:27]

Done.

-  0x0f, 0x0e, 0xa7, 0x94, 0x37, 0x6b, 0x60, 0x9a,
-  0x90, 0x09, 0x3e, 0xbb, 0xce, 0xe8, 0xd7, 0x4b,
-  0xc2, 0x78, 0x17, 0x43, 0x63, 0xd5, 0xb4, 0x43,
-  0xc1, 0x49, 0xc6, 0x44, 0x40, 0x43, 0xae, 0x2a,
+  0x75, 0xda, 0xf8, 0xcb, 0x77, 0x68, 0x40, 0x33,
+  0x65, 0x4c, 0x97, 0xe5, 0xc5, 0x1b, 0xcd, 0x81,
+  0x7b, 0x1e, 0xeb, 0x11, 0x2c, 0xe1, 0xa4, 0x33,
+  0x8c, 0xf5, 0x72, 0x5e, 0xed, 0xb8, 0x43, 0x97,
 };
 
 void CRLSetFetcher::RegisterComponent(uint32 sequence_of_loaded_crl) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   CrxComponent component;
   component.pk_hash.assign(&kPublicKeySHA256[0],

[wtc, 2011/10/21 23:17:31]

Nit: you can just say kPublicKeySHA256,

[agl, 2011/10/24 20:44:27]

Done.

                            &kPublicKeySHA256[0] + sizeof(kPublicKeySHA256));
   component.installer = this;
   component.name = "CRLSet";
   component.version = Version(base::UintToString(sequence_of_loaded_crl));
   if (!component.version.IsValid()) {
     NOTREACHED();
     component.version = Version("0");
   }
 
   if (cus_->RegisterComponent(component) !=
@@ skipping 11 matching lines @@
                             const FilePath& unpack_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
   FilePath crl_set_file_path = unpack_path.Append(FILE_PATH_LITERAL("crl-set"));
   FilePath save_to;
   if (!GetCRLSetFilePath(&save_to))
     return true;
   LoadFromDisk(crl_set_file_path, save_to, NULL);
   return true;
 }