Added Protector, hooked up DSE verification with error bubble.

chrome/browser/protector/settings_change_global_error.h

Index: chrome/browser/protector/settings_change_global_error.h
diff --git a/chrome/browser/protector/settings_change_global_error.h b/chrome/browser/protector/settings_change_global_error.h
index 9e08df87e1308c5fc2ff50332ea22d01ac7a18d2..1864950cf98682fc73ecec78f8b2d6d55ae752e6 100644
--- a/chrome/browser/protector/settings_change_global_error.h
+++ b/chrome/browser/protector/settings_change_global_error.h
@@ -6,44 +6,51 @@
 #define CHROME_BROWSER_PROTECTOR_SETTINGS_CHANGE_GLOBAL_ERROR_H_
 #pragma once
 
-#include <vector>
-
 #include "base/basictypes.h"
-#include "base/callback.h"
 #include "base/compiler_specific.h"
-#include "base/string16.h"
 #include "base/memory/weak_ptr.h"
+#include "chrome/browser/protector/setting_change.h"
 #include "chrome/browser/ui/global_error.h"
 
+class Browser;
 class Profile;
 
+namespace protector {
+
 // Global error about unwanted settings changes.
 class SettingsChangeGlobalError : public GlobalError {
  public:
-  enum ChangeType {
-    kSearchEngineChanged = 0,  // Default search engine has been changed.
-    kHomePageChanged,          // Home page has been changed.
-  };
+  // Interface for notifications about bubble closing.
+  class Delegate {

[sky, 2011/10/21 21:34:11]

This should be in its own header so that you don't have to include
settings_change_global_error.h to implement it.

[whywhat, 2011/10/24 15:30:17]

Done.

+   public:
+    virtual ~Delegate() {}
 
-  struct Change {
-    ChangeType type;       // Which setting has been changed.
-    string16 old_setting;  // Old setting value or "" if unknown.
-    string16 new_setting;  // New setting value.
-  };
+    // Called if user clicks "Apply change" button.
+    virtual void OnApplyChanges() = 0;
 
-  typedef std::vector<Change> ChangesVector;
+    // Called if user clicks "Discard change" button.
+    virtual void OnDiscardChanges() = 0;
 
-  // Creates new global error about settings changes |changes|.
-  // If user decides to apply changes, |apply_changes_cb| is called.
-  // If user decides to keep previous settings, |revert_changes_cb| is called.
-  SettingsChangeGlobalError(const ChangesVector& changes,
-                            const base::Closure& apply_changes_cb,
-                            const base::Closure& revert_changes_cb);
+    // Called if user clicked outside the bubble and timeout for its reshow
+    // has passed.
+    virtual void OnDecisionTimeout() = 0;
+  };
+
+  // Creates new global error about settings changes |changes|. Takes
+  // ownership over |changes| contents.
+  // Uses |delegate| to notify about user decision.
+  SettingsChangeGlobalError(const SettingChangeVector& changes,
+                            Delegate* delegate);
   virtual ~SettingsChangeGlobalError();
 
-  // Displays a global error bubble for the default browser profile.
+  // Displays a global error bubble for the given browser profile.
   // Can be called from any thread.
-  void ShowForDefaultProfile();
+  void ShowForProfile(Profile* profile);
+
+  // Browser that the bubble has been last time shown for.
+  Browser* browser() const { return browser_; }
+
+  SettingChangeVector* mutable_changes() { return &changes_; }
 
   // GlobalError implementation.
   virtual bool HasBadge() OVERRIDE;
@@ -62,30 +69,36 @@ class SettingsChangeGlobalError : public GlobalError {
   virtual void BubbleViewCancelButtonPressed() OVERRIDE;
 
  private:
-  ChangesVector changes_;
+  // Helper called on the UI thread to add this global error to the default
+  // profile (stored in |profile_|).
+  void AddToProfile(Profile* profile);
+
+  // Displays global error bubble. Must be called on the UI thread.
+  void Show();
+
+  // Removes global error from its profile and deletes |this| later.
+  void RemoveFromProfile();
 
-  base::Closure apply_changes_cb_;
-  base::Closure revert_changes_cb_;
+  // List of changes to show.
+  SettingChangeVector changes_;
+
+  // Delegate to notify about user actions.
+  Delegate* delegate_;
 
   // Profile that we have been added to.
   Profile* profile_;
 
+  // Browser that we have been shown for.
+  Browser* browser_;
+
   // True if user has dismissed the bubble by clicking on one of the buttons.
   bool closed_by_button_;
 
   base::WeakPtrFactory<SettingsChangeGlobalError> weak_factory_;
 
-  // Helper called on the UI thread to add this global error to the default
-  // profile (stored in |profile_|).
-  void AddToDefaultProfile();
-
-  // Displays global error bubble. Must be called on the UI thread.
-  void Show();
-
-  // Removes global error from its profile and deletes |this| later.
-  void RemoveFromProfile();
-
   DISALLOW_COPY_AND_ASSIGN(SettingsChangeGlobalError);
 };
 
+}  // namespace protector
+
 #endif  // CHROME_BROWSER_PROTECTOR_SETTINGS_CHANGE_GLOBAL_ERROR_H_