Added Protector, hooked up DSE verification with error bubble.

chrome/browser/webdata/keyword_table.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/webdata/keyword_table.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/string_number_conversions.h"
 #include "base/string_split.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/history/history_database.h"
+#include "chrome/browser/protector/histograms.h"
+#include "chrome/browser/protector/protector.h"
 #include "chrome/browser/search_engines/template_url.h"
-#include "crypto/hmac.h"
 #include "googleurl/src/gurl.h"
 #include "sql/statement.h"
 
 using base::Time;
 
 namespace {
 
 // ID of the url column in keywords.
 const int kUrlIdPosition = 18;
 
 // Keys used in the meta table.
 const char kDefaultSearchProviderKey[] = "Default Search Provider ID";
 const char kBuiltinKeywordVersion[] = "Builtin Keyword Version";
 
-// Key for signing the default search provider backup.
-// TOOD(avayvod): Add key for Google Chrome to internal repository.
-const char kDefaultSearchProviderBackupSigningKey[] =
-    "Please, don't change default search engine!";
-
 // Meta table key to store backup value for the default search provider.
 const char kDefaultSearchProviderBackupKey[] =
     "Default Search Provider ID Backup";
 
 // Meta table key to store backup value signature for the default search
 // provider.
 const char kDefaultSearchProviderBackupSignatureKey[] =
     "Default Search Provider ID Backup Signature";
 
-// Histogram name to report protection errors for the default search
-// provider.
-const char kProtectorHistogramDefaultSearchProvider[] =
-    "Protector.DefaultSearchProvider";
-
-// Protector histogram values. TODO(avayvod): Move to protector.h/cc
-enum ProtectorError {
-  kProtectorErrorBackupInvalid,
-  kProtectorErrorValueChanged,
-
-  // This is for convenience only, must always be the last.
-  kProtectorErrorCount
-};
-
 void BindURLToStatement(const TemplateURL& url, sql::Statement* s) {
   s->BindString(0, UTF16ToUTF8(url.short_name()));
   s->BindString(1, UTF16ToUTF8(url.keyword()));
   GURL favicon_url = url.GetFaviconURL();
   if (!favicon_url.is_valid()) {
     s->BindString(2, std::string());
   } else {
     s->BindString(2, history::HistoryDatabase::GURLToDatabaseURL(
         url.GetFaviconURL()));
   }
@@ skipping 16 matching lines @@
   s->BindInt(13, url.logo_id());
   s->BindBool(14, url.created_by_policy());
   s->BindString(15, url.instant_url() ? url.instant_url()->url() :
                 std::string());
   s->BindInt64(16, url.last_modified().ToTimeT());
   s->BindString(17, url.sync_guid());
 }
 
 // Signs search provider id and returns its signature.
 std::string GetSearchProviderIDSignature(int64 id) {
-  crypto::HMAC hmac(crypto::HMAC::SHA256);
-  DCHECK(hmac.Init(kDefaultSearchProviderBackupSigningKey));
-
-  std::string id_to_sign(base::Int64ToString(id));
-  std::vector<unsigned char> digest(hmac.DigestLength());
-  DCHECK(hmac.Sign(id_to_sign, &digest[0], digest.size()));
-
-  return std::string(&digest[0], &digest[0] + digest.size());
+  return protector::SignSetting(base::Int64ToString(id));
 }
 
 // Checks if signature for search provider id is correct and returns the
 // result.
 bool IsSearchProviderIDValid(int64 id, const std::string& signature) {
   return signature == GetSearchProviderIDSignature(id);
 }
 
 }  // anonymous namespace
 
@@ skipping 162 matching lines @@
 }
 
 bool KeywordTable::SetDefaultSearchProviderID(int64 id) {
   return meta_table_->SetValue(kDefaultSearchProviderKey, id) &&
       SetDefaultSearchProviderBackupID(id);
 }
 
 int64 KeywordTable::GetDefaultSearchProviderID() {
   int64 value = 0;
   meta_table_->GetValue(kDefaultSearchProviderKey, &value);
+  return value;
+}
+
+int64 KeywordTable::GetDefaultSearchProviderIDBackup() {
   int64 backup_value = 0;
   meta_table_->GetValue(kDefaultSearchProviderBackupKey, &backup_value);
   std::string backup_signature;
   meta_table_->GetValue(
       kDefaultSearchProviderBackupSignatureKey, &backup_signature);
-  // For now only track how often signature or backup is lost or value is
-  // changed. Don't change the value since UI is not working yet.
+  if (!IsSearchProviderIDValid(backup_value, backup_signature))
+    return 0;
+  return backup_value;
+}
+
+bool KeywordTable::DidDefaultSearchProviderChange() {
+  int64 backup_value = 0;
+  meta_table_->GetValue(kDefaultSearchProviderBackupKey, &backup_value);
+  std::string backup_signature;
+  meta_table_->GetValue(
+      kDefaultSearchProviderBackupSignatureKey, &backup_signature);
   if (!IsSearchProviderIDValid(backup_value, backup_signature)) {
-    UMA_HISTOGRAM_ENUMERATION(kProtectorHistogramDefaultSearchProvider,
-                              kProtectorErrorBackupInvalid,
-                              kProtectorErrorCount);
-    SetDefaultSearchProviderBackupID(value);
-  } else if (value != backup_value) {
-    UMA_HISTOGRAM_ENUMERATION(kProtectorHistogramDefaultSearchProvider,
-                              kProtectorErrorValueChanged,
-                              kProtectorErrorCount);
-    SetDefaultSearchProviderBackupID(value);
+    UMA_HISTOGRAM_ENUMERATION(
+        protector::kProtectorHistogramDefaultSearchProvider,
+        protector::kProtectorErrorBackupInvalid,
+        protector::kProtectorErrorCount);
+    return true;
+  } else if (backup_value != GetDefaultSearchProviderID()) {
+    UMA_HISTOGRAM_ENUMERATION(
+        protector::kProtectorHistogramDefaultSearchProvider,
+        protector::kProtectorErrorValueChanged,
+        protector::kProtectorErrorCount);
+    return true;
   }
-  return value;
+  return false;
 }
 
 bool KeywordTable::SetBuiltinKeywordVersion(int version) {
   return meta_table_->SetValue(kBuiltinKeywordVersion, version);
 }
 
 int KeywordTable::GetBuiltinKeywordVersion() {
   int version = 0;
   if (!meta_table_->GetValue(kBuiltinKeywordVersion, &version))
     return 0;
@@ skipping 87 matching lines @@
   return
       meta_table_->SetValue(kDefaultSearchProviderBackupKey, id) &&
       SetDefaultSearchProviderBackupIDSignature(id);
 }
 
 bool KeywordTable::SetDefaultSearchProviderBackupIDSignature(int64 id) {
   return meta_table_->SetValue(
       kDefaultSearchProviderBackupSignatureKey,
       GetSearchProviderIDSignature(id));
 }