Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: remoting/host/screen_recorder_unittest.cc

Issue 8342040: Gather history of capture and encode time determine next recoring delay (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: done Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/screen_recorder_unittest.cc
diff --git a/remoting/host/screen_recorder_unittest.cc b/remoting/host/screen_recorder_unittest.cc
index 05c0904e4467ecaad7d2abeb59e81e99e7ba57a8..3a20283993f902e0644c802d17ba16a7d1d05dbc 100644
--- a/remoting/host/screen_recorder_unittest.cc
+++ b/remoting/host/screen_recorder_unittest.cc
@@ -102,52 +102,6 @@ class ScreenRecorderTest : public testing::Test {
DISALLOW_COPY_AND_ASSIGN(ScreenRecorderTest);
};
-// This test mocks capturer, encoder and network layer to operate one recording
-// cycle.
-TEST_F(ScreenRecorderTest, OneRecordCycle) {
Sergey Ulanov 2011/11/10 00:39:12 What's the reason to remove this test?
- SkRegion update_region(SkIRect::MakeXYWH(0, 0, 10, 10));
- DataPlanes planes;
- for (int i = 0; i < DataPlanes::kPlaneCount; ++i) {
- planes.data[i] = reinterpret_cast<uint8*>(i);
- planes.strides[i] = kWidth * 4;
- }
- SkISize size(SkISize::Make(kWidth, kHeight));
- scoped_refptr<CaptureData> data(new CaptureData(planes, size, kFormat));
- EXPECT_CALL(capturer_, InvalidateFullScreen());
-
- // First the capturer is called.
- EXPECT_CALL(capturer_, CaptureInvalidRegion(NotNull()))
- .WillOnce(RunCallback(update_region, data));
-
- // Expect the encoder be called.
- EXPECT_CALL(*encoder_, Encode(data, false, NotNull()))
- .WillOnce(FinishEncode());
-
- MockVideoStub video_stub;
- EXPECT_CALL(*connection_, video_stub())
- .WillRepeatedly(Return(&video_stub));
-
- // Expect the client be notified.
- EXPECT_CALL(video_stub, ProcessVideoPacket(_, _))
- .Times(1)
- .WillOnce(DeleteArg<0>());
- EXPECT_CALL(video_stub, GetPendingPackets())
- .Times(AtLeast(0))
- .WillRepeatedly(Return(0));
-
- // Set the recording rate to very low to avoid capture twice.
- record_->SetMaxRate(0.01);
-
- // Add the mock client connection to the session.
- record_->AddConnection(connection_);
-
- // Start the recording.
- record_->Start();
-
- // Make sure all tasks are completed.
- message_loop_.RunAllPending();
-}
-
// This test mocks capturer, encoder and network layer to simulate one recording
// cycle. When the first encoded packet is submitted to the network
// ScreenRecorder is instructed to come to a complete stop. We expect the stop

Powered by Google App Engine
This is Rietveld 408576698